leahi-common

Clone Tools

Stats

Commits this week: 30
Total Committers: 18
Last Commit: 08:54
Commits this week: 30

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 mins ago

Vendor - TEL - Varshini Nagabooshanam

@details \b Inputs:

@details \b Inputs:

3 mins ago

Vendor - TEL - Varshini Nagabooshanam

@details \b Outputs: Please make sure to update all of them to Leahi format (see from other units for example). In this case, there should be a \b before the type of details (Inputs and Outputs her...

@details \b Outputs:
Please make sure to update all of them to Leahi format (see from other units for example). In this case, there should be a \b before the type of details (Inputs and Outputs here) so they will be bold when doxygen documentation is generated.

7 mins ago

Vendor - TEL - Arpita Srivastava

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

Can we please add more comments in this function to explain the rationale behind the checks and the actions?

22 mins ago

Vendor - TEL - Arpita Srivastava

add typedef

add typedef

22 mins ago

Vendor - TEL - Arpita Srivastava

add typedef

add typedef

23 mins ago

Vendor - TEL - Arpita Srivastava

We can delete line 45 and 46. And update line 44 to } TUBE_SET_INSTALL_STATE_T;

We can delete line 45 and 46. And update line 44 to } TUBE_SET_INSTALL_STATE_T;

24 mins ago

Vendor - TEL - Arpita Srivastava

We can delete line 46 and 47 and update line 45 to } TUBE_SET_AUTO_EJECT_STATE_T;

We can delete line 46 and 47 and update line 45 to } TUBE_SET_AUTO_EJECT_STATE_T;

29 mins ago

Vendor - TEL - Arpita Srivastava

add a space between message and )

add a space between message and )

33 mins ago

Vendor - TEL - Arpita Srivastava

Change // to /// for doxygen to catch it.

Change // to /// for doxygen to catch it.

49 mins ago

Vendor - TEL - Arpita Srivastava

Can we remove the parameter and switch directly over currentPostTreatmentState?

Can we remove the parameter and switch directly over currentPostTreatmentState?

51 mins ago

Vinayakam Mani

Do we need D48 speed udpate for BCswitch only status?

Do we need D48 speed udpate for BCswitch only status?

59 mins ago

Vendor - TEL - Arpita Srivastava

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

The public function name signalGoToInstallState is not sufficiently descriptive. Would renaming it to requestTubeSetInstall() be appropriate?

1 hr ago

Vinayakam Mani

Check the else portion and do the required changes.

Check the else portion and do the required changes.

1 hr ago

Sean Nash

I prefer you create a local BOOL result so you can have a simpler return statement.

I prefer you create a local BOOL result so you can have a simpler return statement.

1 hr ago

Sean Nash

Should go to your new complete state here.

Should go to your new complete state here.

1 hr ago

Vendor - TEL - Arpita Srivastava

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

The number looks incorrect. This was an issue in the staging branch, which is fixed now. Can you please pull latest staging and update the values of your enums?

2 hrs ago

Dara Navaei

Merge branch 'staging' into LDT-3259-software-update---td-firmware

Options
    • -2
    • +3
    /MsgDefs.h
4 hrs ago

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /MsgDefs.h
Monday 04 May
4:47 pm

Vendor - TEL - Arpita Srivastava

LDT-3505: Added msg ids for syringe pump module

Options
    • -2
    • +16
    /MsgDefs.h
4:30 pm

Sean Nash

check alarm status instead of switch state.

check alarm status instead of switch state.

4:15 pm

Vinayakam Mani

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

Name something similar to 'BCSwitchingBasedOnClosePeriodCounter'?

4:03 pm

Vinayakam Mani

I guess, all these checks should be moved to FillEndState.

I guess, all these checks should be moved to FillEndState.

3:52 pm

Vinayakam Mani

after one state of BC switching completed. update the next comment as well.

after one state of BC switching completed. update the next comment as well.

3:34 pm

Vendor - TEL - Vijay Pamula

LDT-3970: Added new rejection reason for confirmation flow handling

Options
    • -0
    • +2
    /MsgDefs.h
2:30 pm

Vendor - TEL - Jashwant Gantyada

LDY-3963 merged latest staging

Options
11:04 am

Vendor - TEL - Varshini Nagabooshanam

Uncommented

Uncommented

10:19 am

Vendor - TEL - Varshini Nagabooshanam

LDT-2240-disposable-tube-set-self-test

Options
    • -6
    • +11
    /MsgDefs.h
    • -38
    • +84
    /TDDefs.h
9:59 am

Vendor - TEL - Arpita Srivastava

Should we add a TODO to remove this one as well?

Should we add a TODO to remove this one as well?

9:57 am

Vendor - TEL - Arpita Srivastava

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

If we are removing this call, then where are we calling the function testDDFloaterLevelStateOverride?

9:44 am

Vendor - TEL - Arpita Srivastava

Please update the function name : testDDFloaterLevelStateOverride

Please update the function name : testDDFloaterLevelStateOverride