leahi-common

AlarmDefs.h

Clone Tools

Stats

Commits this week: 7
Total Committers: 17
Last Commit: 13:33
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Jun
4:10 pm

Vendor - TEL - Varshini Nagabooshanam

Crucible fixes

Options
    • -15
    • +20
    /AlarmDefs.h
3:20 pm

Vendor - TEL - Varshini Nagabooshanam

Merge fixes

Options
    • -31
    • +37
    /AlarmDefs.h
  2. … 1 more file in changeset.
2:34 pm

Vendor - TEL - Arpita Srivastava

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

2:28 pm

Vendor - TEL - Arpita Srivastava

please remove extra line

please remove extra line

2:26 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:23 pm

Vendor - TEL - Arpita Srivastava

Please add message id.

Please add message id.

2:22 pm

Vendor - TEL - Arpita Srivastava

Output is none

Output is none

2:21 pm

Vendor - TEL - Arpita Srivastava

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

12:50 pm

Sean Nash

Include "BPModule.h".

Include "BPModule.h".

12:49 pm

Sean Nash

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.

12:48 pm

Sean Nash

We should not comment this out.

We should not comment this out.

12:47 pm

Sean Nash

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

12:46 pm

Sean Nash

We are already executing this from TaskGeneral.c. Remove from here.

We are already executing this from TaskGeneral.c. Remove from here.

12:45 pm

Sean Nash

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

12:43 pm

Sean Nash

I think all flags are outputs (not just adult).

I think all flags are outputs (not just adult).

12:41 pm

Sean Nash

These look like outputs to me (not inputs).

These look like outputs to me (not inputs).

10:14 am

suresh

Updated alarm and msgdefs per review

Options
    • -2
    • +6
    /AlarmDefs.h
  2. … 1 more file in changeset.
Tuesday 23 Jun
9:53 am

Vendor - TEL - Varshini Nagabooshanam

Merge fixes

Options
    • -6
    • +10
    /AlarmDefs.h
Monday 22 Jun
5:39 pm

Sean Nash

Can we restore this code?

Can we restore this code?

5:36 pm

Sean Nash

Remove FANS test.

Remove FANS test.

5:34 pm

Sean Nash

Remove.

Remove.

5:33 pm

Sean Nash

Move this to Messaging.c

Move this to Messaging.c

5:32 pm

Sean Nash

Remove. Replaced by generic confirmation functions and messages.

Remove. Replaced by generic confirmation functions and messages.

5:30 pm

Sean Nash

Remove this function - replaced by generic confirmation functions.

Remove this function - replaced by generic confirmation functions.

5:28 pm

Sean Nash

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirm...

Remove this timer code and replace with getConfirmationRequestStatus() and, if status is Accepted, do confirmation code above. If status is Rejected or TimedOut, clear offRequestAwaitingUserConfirmation flag.

5:24 pm

Sean Nash

Replace with request code above.

Replace with request code above.

5:23 pm

Sean Nash

Remove this function after you've moved what we need.

Remove this function after you've moved what we need.

5:23 pm

Sean Nash

No need for these elses.

No need for these elses.

5:22 pm

Sean Nash

Remove send function call.

Remove send function call.

5:22 pm

Sean Nash

Move this code inside if statement to handleOffButtonProcessing() where same if statement exists.

Move this code inside if statement to handleOffButtonProcessing() where same if statement exists.