leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 16
Total Committers: 18
Last Commit: 14:50
Commits this week: 16

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 May
9:07 am

Sean Nash

Add a banner before Dialin test support functions (see other units for example).

Add a banner before Dialin test support functions (see other units for example).

9:04 am

Sean Nash

Initialize .override to OVERRIDE_RESET

Initialize .override to OVERRIDE_RESET

9:03 am

Sean Nash

Why is this commented out? Do we not need to initialize it?

Why is this commented out? Do we not need to initialize it?

Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

leak in the comment section.

leak in the comment section.

3:34 pm

Sean Nash

Where is alarm 191..203?

Where is alarm 191..203?

2:33 pm

Sean Nash

2:30 pm

Sean Nash

Align comment.

Align comment.

2:24 pm

Sean Nash

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

2:20 pm

Sean Nash

Should this line be un-commented?

Should this line be un-commented?

2:19 pm

Sean Nash

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

2:16 pm

Sean Nash

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

9:27 am

Sean Nash

Rename similar to ADDR definitions below. these are not commands.

Rename similar to ADDR definitions below. these are not commands.

9:14 am

Sean Nash

Combine charger and pack data into one payload with one broadcast message.

Combine charger and pack data into one payload with one broadcast message.

9:12 am

Sean Nash

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

Move these 3 override messages (should end in OVERRIDE_REQUEST) to TD Dialin section below and assign an ID in the 0x8... range.

9:11 am

Sean Nash

I think we only need one data message for both charger and battery pack data.

I think we only need one data message for both charger and battery pack data.

9:09 am

Sean Nash

Remove.

Remove.

9:09 am

Sean Nash

uncomment.

uncomment.

Monday 18 May
9:45 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Sunday 17 May
11:46 pm

Sean Nash

Why was this function header changed? I think it was correct before.

Why was this function header changed? I think it was correct before.

11:37 pm

Sean Nash

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

If these messages are for change to UF volume during treatment, the message ID should have the word TREATMENT in it to distinguish from the original UF volume message that comes in pre-treatment.

11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.