Lines of code count not available
Alphabetize.
Comment this out before merge.
Yes. The integrity module is in leahi-fwcommon repository, and it serves both TD and DD.
These are located in the integrity.c
Yes the ECC checks are done in the bootloader stack.
remove camel case for SetPoint, instead use Setpoint Update line 659 too
Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T
Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?
What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.
Looks like comment for 208 and 223 are swapped?
please align the comments
Please update the msg id to MSG_ID_TD_TREATMENT_SET_POINT_DIALYSATE_TEMP_CHANGE_RESPONSE
Please break it into two lines and check other functions too.
Please break it into two lines
Please break it into two lines Should the name of the message id be MSG_ID_TD_TREATMENT_UF_VOLUME_VALIDATE_RESPONSE?
TREAT_PARAMS_PROPERTIES should also be an input?
please add @param
please align the comment
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.