leahi-dialin / leahi_dialin

fp

Clone Tools

Stats

Commits this week: 3
Total Committers: 8
Last Commit: 08:42
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Apr
12:05 pm

Vendor - TEL - Sameer Poyil

LDT-3984 addressed review comments

Options
    • -1
    • +1
    ./modules/levels.py
Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

8:44 pm

Vendor - TEL - Sameer Poyil

LDT-3984 fix for conductivie level sensors d46, d63,d98

Options
    • -1
    • +3
    ./modules/levels.py
  2. … 3 more files in changeset.
Sunday 26 Apr
2:46 pm

Sean Nash

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

Friday 24 Apr
10:45 pm

Vendor - TEL - Sameer Poyil

LDT-3984 conductive level sensor dialin implementation

Options
    • -3
    • +5
    ./modules/levels.py
  2. … 2 more files in changeset.
Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Friday 10 Apr
10:20 am

Zoltan Miskolci

Thursday 09 Apr
3:48 pm

Zoltan Miskolci

Merge branch 'LDT-3910-td_test_conf' into develop

Options
    • -9
    • +8
    ./filtration_purification.py
3:20 pm

Raghu Kallala and Michael Garthwaite

3:03 pm

Zoltan Miskolci

-Added TD test config - Updated fp get requests based on latest change in FW

Options
    • -9
    • +8
    ./filtration_purification.py
  2. … 1 more file in changeset.
3:00 pm

Dara Navaei

LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
Wednesday 08 Apr
11:26 am

Zoltan Miskolci

11:16 am

Zoltan Miskolci

Merge branch 'LDT-3824-state_machine_update' into develop

Options
    • -3
    • +3
    ./filtration_purification.py
10:01 am

Michael Garthwaite and Raghu Kallala

9:52 am

Zoltan Miskolci

CR fixes

Options
    • -3
    • +3
    ./filtration_purification.py
9:48 am

Raghu Kallala

Typo, response

Typo, response

9:48 am

Raghu Kallala

Typo, response

Typo, response

9:47 am

Raghu Kallala

Fix the header

Fix the header

Friday 03 Apr
10:17 am

Zoltan Miskolci

Merge branch 'LDT-3824-state_machine_update' into develop

Options
    • -8
    • +6
    ./filtration_purification.py
  2. … 4 more files in changeset.
Thursday 02 Apr
11:13 am

Zoltan Miskolci

enum updates

Options
    • -7
    • +6
    ./filtration_purification.py
  2. … 10 more files in changeset.
Tuesday 31 Mar
10:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
Monday 30 Mar
2:33 pm

Zoltan Miskolci

2:10 pm

Zoltan Miskolci

Merge branch 'LDT-696-tc-implement-lvtc-13' into develop

Options
    • -16
    • +12
    ./filtration_purification.py
11:30 am

Michael Garthwaite

9:39 am

Sean Nash