Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDT-3984 addressed review comments

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

LEVEL_OFFSET?

LDT-3984 fix for conductivie level sensors d46, d63,d98

  1. … 3 more files in changeset.
Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

LDT-3984 conductive level sensor dialin implementation

  1. … 2 more files in changeset.
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Merge branch 'LDT-3910-td_test_conf' into develop

-Added TD test config - Updated fp get requests based on latest change in FW

  1. … 1 more file in changeset.
LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
Merge branch 'LDT-3824-state_machine_update' into develop

CR fixes

Typo, response

Typo, response

Typo, response

Typo, response

Fix the header

Fix the header

Merge branch 'LDT-3824-state_machine_update' into develop

  1. … 4 more files in changeset.
enum updates

  1. … 10 more files in changeset.
LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
Merge branch 'LDT-696-tc-implement-lvtc-13' into develop