leahi-dialin

leahi_dialin

Clone Tools

Stats

Commits this week: 19
Total Committers: 15
Last Commit: 30 Apr
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
8:17 pm

Michael Garthwaite

LDT-4000: fix to unit testing

Options
    • -1
    • +2
    ./common/msg_ids.py
8:14 pm

Michael Garthwaite

LDT-4000: fix to msg ids

Options
    • -3
    • +0
    ./common/msg_ids.py
5:16 pm

Michael Garthwaite

Merge branch 'LDT-4000-hdf-fw-implementation-1-4' into develop

Options
    • -2
    • +2
    ./common/msg_ids.py
5:16 pm

Michael Garthwaite

LDT-4000: swapped override requests.

Options
    • -2
    • +2
    ./common/msg_ids.py
4:54 pm

Michael Garthwaite

Merge branch 'LDT-4000-hdf-fw-implementation-1-4' into develop

Options
    • -1
    • +19
    ./common/msg_ids.py
4:54 pm

Michael Garthwaite

LDT-4000: updated message IDs. Updated test config for beta 1.9 and 2.0. implemented substitution pump module

Options
    • -1
    • +19
    ./common/msg_ids.py
    • -1
    • +1
    ./common/test_config_defs.py
    • -1
    • +3
    ./dd/dialysate_delivery.py
    • -0
    • +112
    ./dd/modules/substitution_pump.py
4:33 pm

Vendor - TEL - Sameer Poyil

4:28 pm

Michael Garthwaite and Raghu Kallala

3:51 pm

Zoltan Miskolci

Merge branch 'LDT-4188-sw-fw-integration-to-run-a-trea' into develop

Options
    • -26
    • +39
    ./dd/proxies/td_proxy.py
3:34 pm

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
3:28 pm

Vendor - TEL - Sameer Poyil

LDT-3984-unit-test-failure-fix

Options
    • -1
    • +1
    ./dd/modules/levels.py
2:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
2:23 pm

Vendor - TEL - Sameer Poyil

2:22 pm

Michael Garthwaite

LDT-4000: fixed unit testing

Options
    • -1
    • +1
    ./dd/modules/levels.py
2:14 pm

Michael Garthwaite , Vinayakam Mani and Sean Nash

11:45 am

Vendor - TEL - Sameer Poyil

Merge branch staging into LDT-3984-dd-sw-d46-reads-0-with-and-with

Options
    • -2
    • +2
    ./common/dd_defs.py
9:32 am

Zoltan Miskolci

- Updated td_proxy - Added requests to UI_proxy - Updated generic override

Options
    • -3
    • +3
    ./common/override_templates.py
    • -21
    • +31
    ./dd/proxies/td_proxy.py
    • -19
    • +51
    ./td/modules/alarms.py
    • -40
    • +84
    ./td/proxies/ui_proxy.py
9:30 am

Dara Navaei

LEAHI-DIALIN-LDT-4188_SW/FW integration to run a Treatment from UI
LEAHI-DIALIN-LDT-4188_SW/FW integration to run a Treatment from UI
Wednesday 29 Apr
12:05 pm

Vendor - TEL - Sameer Poyil

LDT-3984 addressed review comments

Options
    • -1
    • +1
    ./fp/modules/levels.py
Tuesday 28 Apr
4:16 pm

Nicholas Ramirez

LDT-4221 NON-FEATURE: SW Misc & Enhc - SW - 01 - Create Rx - Final Flag Prm - R&I - 08: DEV - Dialin Implementation

remove fijnal rejection reason

Options
    • -3
    • +0
    ./ui/td_messaging.py
3:30 pm

Nicholas Ramirez

LDT-4221 NON-FEATURE: SW Misc & Enhc - SW - 01 - Create Rx - Final Flag Prm - R&I - 08: DEV - Dialin Implementation

update to add final flag

Options
    • -0
    • +3
    ./ui/td_messaging.py
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

8:59 am

Sean Nash

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

8:44 pm

Vendor - TEL - Sameer Poyil

LDT-3984 fix for conductivie level sensors d46, d63,d98

Options
    • -5
    • +5
    ./common/dd_defs.py
    • -1
    • +2
    ./common/fp_defs.py
    • -3
    • +2
    ./dd/modules/levels.py
    • -1
    • +3
    ./fp/modules/levels.py
3:48 pm

Nicholas Ramirez

LDT-4169 Post-Treatment - SW - 01 - TxReview - R&I - 08: DEV - Dialin Implementation

push dialin updated

Options
    • -1
    • +0
    ./common/msg_ids.py
    • -2
    • +164
    ./ui/td_messaging.py