leahi-fwcommon

Clone Tools

Stats

Commits this week: 15
Total Committers: 13
Last Commit: 13 Mar
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
12:23 pm

Vendor - TEL - Jashwant Gantyada

LDT-3103 addressed code review comments and changes

Options
    • -1
    • +1
    /TestSupport.h
10:50 am

Sean Nash

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

I don't see a TODO. If we intend to uncomment this line out later, we should add a TODO comment to the right as a reminder. If we do not intend to uncomment this later, we should just delete it.

10:48 am

Sean Nash

Fix alignment of "=".

Fix alignment of "=".

10:47 am

Sean Nash

Add a param line in this header.

Add a param line in this header.

10:47 am

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

10:46 am

Sean Nash

Add a params line in function header.

Add a params line in function header.

10:45 am

Sean Nash

Why did we change this spelling? Now it's wrong.

Why did we change this spelling? Now it's wrong.

10:44 am

Sean Nash

Can we delete this commented out line?

Can we delete this commented out line?

10:43 am

Sean Nash

Keep this blank line.

Keep this blank line.

10:41 am

Sean Nash

Should be before ModeStandby.

Should be before ModeStandby.

10:40 am

Sean Nash

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

I see we are doing this same logic in multiple places. Can we just have a function that returns the minimum speed for the given dialysate pump?

10:37 am

Sean Nash

Remove blank line.

Remove blank line.

10:37 am

Sean Nash

Remove blank line.

Remove blank line.

10:36 am

Sean Nash

Should assign a local variable to this equation and then return the variable. Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int. Al...

Should assign a local variable to this equation and then return the variable.
Can this equation result in a negative number? If so, we should handle that first before converting to unsigned int.
Also, do we want to do any rounding when converting float to integer?

10:32 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:32 am

Vendor - TEL - Jashwant Gantyada

The TODO has already been mentioned in staging. They have it commented out for strike and hold behavior.

The TODO has already been mentioned in staging. They have it commented out for strike and hold behavior.

Wednesday 11 Mar
5:45 pm

Vendor - TEL - Praneeth Bunne

Add TEST_CONFIG_TESTING_WITHOUT_TUBING_SET test configuration enum.

Options
    • -0
    • +1
    /TestSupport.h
3:31 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
LEAHI-TD-FIRMWARE-LDT-3600_Request for TD Test Config for Testing without Tubing Set on TD
9:34 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'develop' of bitbucket.org:diality-cloud/leahi-fwcommon into develop

Options
9:32 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'LDT-3103-implement-closed-loop-control-f' into develop

Options
    • -2
    • +3
    /TestSupport.h
9:31 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 merged latest staging

Options
9:10 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
Tuesday 10 Mar
1:53 pm

Vendor - TEL - Varshini Nagabooshanam

9:43 am

Dara Navaei

Merged staging

Options
    • -2
    • +2
    /TestSupport.h
9:24 am

Vendor - TEL - Arpita Srivastava

LDT-3505: Added Test Config for Syringe Pump

Options
    • -0
    • +1
    /TestSupport.h
Monday 09 Mar
2:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /TestSupport.c
2:03 pm

Dara Navaei

2:01 pm

Dara Navaei

LDT-3605

Options
1:53 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

1:24 pm

Dara Navaei

LDT-3605 updated the test support module

Options
    • -1
    • +1
    /TestSupport.c