leahi-fwcommon

Clone Tools

Stats

Commits this week: 12
Total Committers: 13
Last Commit: 18 Mar
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 18 Mar
5:37 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /Comm.c
    • -1
    • +1
    /Comm.h
1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?

12:55 pm

Sean Nash

This is a structure, not an enumeration.

This is a structure, not an enumeration.

9:52 am

Vendor - TEL - Sameer Poyil

LDT-2004 dialysate dosing control debug control signal

Options
    • -5
    • +49
    /PIControllers.c
    • -0
    • +18
    /PIControllers.h
Monday 16 Mar
2:21 pm

Michael Garthwaite

Merge branch 'LDT-3218-update-iofp-permeate-target-flow' into develop

Options
2:18 pm

Michael Garthwaite

LDT-3218: updated step limit for ro pump

Options
    • -1
    • +1
    /PIControllers.c
11:10 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
10:58 am

Michael Garthwaite

Merge branch 'LDT-2004-v2-conductivity-sensors' into develop

Options
    • -3
    • +4
    /TestSupport.h
10:11 am

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

Options
10:11 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Options
10:11 am

Michael Garthwaite

Merge remote-tracking branch 'origin/staging' into staging

Options
Friday 13 Mar
5:33 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /TestSupport.h
5:22 pm

Vendor - TEL - Praneeth Bunne

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into staging

Options
    • -3
    • +3
    /TestSupport.h
3:21 pm

Vendor - TEL - Praneeth Bunne

2:47 pm

Vinayakam Mani , Vendor - TEL - Jashwant Gantyada and Sean Nash

2:23 pm

Sean Nash

2:11 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /TestSupport.h
2:06 pm

Vendor - TEL - Jashwant Gantyada and Sean Nash

1:45 pm

Vinayakam Mani

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

1:43 pm

Vinayakam Mani

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
1:31 pm

Vinayakam Mani

11:50 am

Vendor - TEL - Jashwant Gantyada

done changed it.

done changed it.

11:37 am

Vinayakam Mani

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

9:33 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?