leahi-fwcommon

Clone Tools

Stats

Commits this week: 10
Total Committers: 13
Last Commit: 11 May
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 11 May
9:42 am

Raghu Kallala

9:07 am

Michael Garthwaite and Sean Nash

Friday 08 May
1:21 pm

Sean Nash

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

Thursday 07 May
11:12 am

Sean Nash

Remove start state.

Remove start state.

10:30 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

updated

updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Yes, removed

Yes, removed

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

yes, removed

yes, removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Changed

Changed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:27 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

10:26 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:25 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Wednesday 06 May
10:30 pm

Vendor - TEL - Varshini Nagabooshanam

1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
10:23 am

Sean Nash

Tuesday 05 May
3:58 pm

Sean Nash

no need to respond.

no need to respond.

3:58 pm

Sean Nash

don't need response to a response.

don't need response to a response.

3:54 pm

Sean Nash

don't need this if statement either and don't need what's inside the if.

don't need this if statement either and don't need what's inside the if.

3:49 pm

Sean Nash

Don't need this if statement or flag.

Don't need this if statement or flag.

3:46 pm

Sean Nash

use separate time than stability (even if same right now).

use separate time than stability (even if same right now).