Activity leahi-fwcommon/

11:15 am

Vinayakam Mani

More
edd0af6
changed 2 files
develop

LDT-3958 resolving merge conflicts

- -1
- +2
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c
- -0
- +1
/PIControllers.h
- History
- Source
- Diff
/PIControllers.h

9:44 am

Raghu Kallala

More
45a3217
changed 0 files
staging

LDT-4188 merge latest to staging

9:42 am

Raghu Kallala

More
b95ba69
changed 0 files
LDT-4188-sw-fw-integration-to-run-a-trea, staging

LDT-4188 merge latest from staging

9:07 am

Michael Garthwaite and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4188-1
finished reviewing

1:21 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

Again, I don't like these oriented this way. Please change to #ifndef DISABLE_ALARM_4

1:19 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
commented on review

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pre...

If BC switching period is Zero, I would expect the Qd from TD to also be zero, right? But what if it's not? What if Qd from TD is 600 and switching period is zero? You are going to run the pump pretty fast with no BC switching in that case.

1:10 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3963-1
replied to Vendor - TEL - Arpita Srivastava

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_) And t...

We shouldn't require something to be defined to do the right thing. We should require something to be defined to do the wrong thing (i.e. this should say #ifndef _BAD_MSG_CRC_ALARM_DISABLED_)
And then, we don't need a TODO. These #defines are only possible in DEBUG builds. A RELEASE build will never allow thing build flags to disable things.

9:21 am

Dara Navaei

More
f50d464
changed 2 files
LDT-4188-sw-fw-integration-to-run-a-trea, staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/PIControllers.c
- History
- Source
- Diff
/PIControllers.c
- -2
- +2
/PIControllers.h
- History
- Source
- Diff
/PIControllers.h

11:12 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-2240-1
commented on review

Remove start state.

10:30 am

Stats

Commits this week: 10

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Michael Garthwaite and Sean Nash