td-firmware / firmware / App / Controllers

BloodFlow.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 5
Last Commit: 04 May
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 03 May
11:46 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BloodFlow.c
  2. … 1 more file in changeset.
11:41 am

Raghu Kallala and Sean Nash

11:33 am

Raghu Kallala

Saturday 02 May
5:51 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3959_Blood Flow Rate - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-3959_Blood Flow Rate - FW Implementation - 1/1:
Friday 01 May
10:29 pm

Sean Nash

LDT-3952: Fixed bug where moving average overflows its buffer when target flow is zero.

Options
    • -22
    • +11
    ./BloodFlow.c
Thursday 23 Apr
11:06 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BloodFlow.c
  2. … 1 more file in changeset.
10:59 am

Vendor - TEL - Jashwant Gantyada

10:55 am

Vendor - TEL - Arpita Srivastava

Wednesday 22 Apr
5:37 pm

Vinayakam Mani and Sean Nash

4:50 pm

Vendor - TEL - Sameer Poyil

1:09 pm

Sean Nash

Tuesday 21 Apr
3:27 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

3:26 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

3:26 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

3:26 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

3:26 pm

Vendor - TEL - Jashwant Gantyada

removed and used default value as they are the same.

removed and used default value as they are the same.

3:26 pm

Vendor - TEL - Jashwant Gantyada

yes. updated.

yes. updated.

3:26 pm

Vendor - TEL - Jashwant Gantyada

updated and used as suggested.

updated and used as suggested.

3:25 pm

Vendor - TEL - Jashwant Gantyada

noted.

noted.

3:25 pm

Vendor - TEL - Jashwant Gantyada

LDT-3959 addressed code review comments

Options
    • -47
    • +34
    ./BloodFlow.c
1:28 pm

Sean Nash

We have a reset function above that does this. Should we call it?

We have a reset function above that does this. Should we call it?

1:26 pm

Sean Nash

Are we filtering at zero set rate? I guess we should, so then the duration would be 1 sec then?

Are we filtering at zero set rate? I guess we should, so then the duration would be 1 sec then?

1:25 pm

Sean Nash

I think minimum samples would be for max rate (500 mL/min), so 3 secs at 20 Hz = 60 samples.

I think minimum samples would be for max rate (500 mL/min), so 3 secs at 20 Hz = 60 samples.

1:24 pm

Sean Nash

PRODUCT should probably come before FILTER_SAMPLES above so that it can be used in that definition. Show derivation again. i.e. (500 * 3) indicating we want 3 seconds of filter duration for 500 mL/...

PRODUCT should probably come before FILTER_SAMPLES above so that it can be used in that definition.
Show derivation again. i.e. (500 * 3) indicating we want 3 seconds of filter duration for 500 mL/min rate and duration grows as rate is reduced.

1:17 pm

Sean Nash

600 will take a lot of memory (600 x 4 bytes = 2.4K). Ok for now, but if memory gets scarce, we will have to consider sampling less frequently to reduce the size of the moving average array. Also,...

600 will take a lot of memory (600 x 4 bytes = 2.4K). Ok for now, but if memory gets scarce, we will have to consider sampling less frequently to reduce the size of the moving average array.

Also, show derivation of this number so it's clear what it means and how we got to 600.
i.e. ((PRODUCT / 50) * (MS_PER_SECOND / TASK_GENERAL_INTERVAL)) indicating how many samples we need to buffer for worst case which is lowest flow rate (50) requiring max duration (30 sec) at 20 Hz sample rate.

12:58 pm

Sean Nash

We typically refer to set blood flow rate as Qb.

We typically refer to set blood flow rate as Qb.

12:57 pm

Sean Nash

Refactor this function to have only one return statement.

Refactor this function to have only one return statement.

9:24 am

Sean Nash

You could just do a memset() here.

You could just do a memset() here.

Friday 17 Apr
3:31 pm

Vendor - TEL - Jashwant Gantyada

LDT-3959 added filtering logic for blood pump for rpm

Options
    • -15
    • +85
    ./BloodFlow.c
Thursday 16 Apr
2:47 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-3959_Blood Flow Rate - FW Implementation - 1/1:
LEAHI-TD-FIRMWARE-LDT-3959_Blood Flow Rate - FW Implementation - 1/1: