leahi-dialin / leahi_dialin / dd / modules

balancing_chamber.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 10 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Mar
1:41 pm

Sean Nash

9:10 am

Dara Navaei

LEAHI-DIALIN-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DIALIN-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
Tuesday 10 Mar
4:19 pm

Vendor - TEL - Arpita Srivastava

LDT-1195: Added variable to keep track of balancing chamber switching activity.

Options
    • -1
    • +4
    ./balancing_chamber.py
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Wednesday 25 Feb
6:57 pm

Zoltan Miskolci

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

Options
    • -9
    • +10
    ./balancing_chamber.py
  2. … 60 more files in changeset.
Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Friday 13 Feb
9:37 am

Vinayakam Mani

Tuesday 10 Feb
1:33 pm

Vendor - TEL - Sameer Poyil , Sean Nash and Zoltan Miskolci

11:23 am

Vendor - TEL - Sameer Poyil

merged staging into dry bicart branch and code is pushed

merged staging into dry bicart branch and code is pushed

11:22 am

Vendor - TEL - Sameer Poyil

New code pushed

New code pushed

9:29 am

Zoltan Miskolci

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place Broadcast -> cmd_generic_broadcast_interval_override others -> cmd_generic_ov...

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

9:26 am

Zoltan Miskolci

This is not the code that is currently on staging, so I think you need to update it from there

This is not the code that is currently on staging, so I think you need to update it from there

Monday 09 Feb
8:57 pm

Vendor - TEL - Sameer Poyil

fixed it

fixed it

5:55 pm

Vendor - TEL - Sameer Poyil

This is a change from Zoltan and I am updated that into my local branch

This is a change from Zoltan and I am updated that into my local branch

4:49 pm

Zoltan Miskolci

1:47 pm

Sean Nash

9:16 am

Michael Garthwaite

This class member is a way for dialin to present all the valve states in a list like so: >>> fp = FP() >>> fp.valves.valve_states_enum [0, 0, 0, 0, 0, 0, 0] It is organized in the order of the e...

This class member is a way for dialin to present all the valve states in a list like so:

>>> fp = FP()
>>> fp.valves.valve_states_enum
[0, 0, 0, 0, 0, 0, 0]


It is organized in the order of the enum that was used to iterate. This is purely for presentation / Quality of life feature for the dialin user. We can remove it if we know users are no longer using it for monitoring

Friday 06 Feb
8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm

Vendor - TEL - Sameer Poyil

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

2:14 pm

Sean Nash

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

10:41 am

Sean Nash

Add a blank line between functions.

Add a blank line between functions.

9:47 am

Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

9:45 am

Zoltan Miskolci

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

9:37 am

Sean Nash

Is this staying? Is all of above replacing this class?

Is this staying? Is all of above replacing this class?

9:30 am

Sean Nash

Is this a dynamic enum?

Is this a dynamic enum?

9:29 am

Sean Nash

What is happening here? Is this a dynamic enum? Where is it used?

What is happening here? Is this a dynamic enum? Where is it used?