leahi-dialin / leahi_dialin / fp / modules

valves.py

Clone Tools

Stats

Commits this week: 3
Total Committers: 6
Last Commit: 13 Mar
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 12 Mar
2:32 pm

Zoltan Miskolci

2:12 pm

Michael Garthwaite and Raghu Kallala

11:50 am

Zoltan Miskolci

Fixed

Fixed

11:48 am

Zoltan Miskolci

added Todo comment

added Todo comment

11:47 am

Zoltan Miskolci

They were added while debugging fp_test_configs and why it's never being updated. Removed.

They were added while debugging fp_test_configs and why it's never being updated.
Removed.

10:59 am

Michael Garthwaite

tip: use the logger and set the statement to error level and you can see it in runtime

tip: use the logger and set the statement to error level and you can see it in runtime

9:51 am

Raghu Kallala

pressure limit will be unsigned int not signed int with LDT-473..beta CR Add a TODO to update once the 473 is ready to merge

pressure limit will be unsigned int not signed int with LDT-473..beta CR
Add a TODO to update once the 473 is ready to merge

9:45 am

Raghu Kallala

Are these print statements add for debugging? If not, is this allowed

Are these print statements add for debugging?
If not, is this allowed

9:36 am

Raghu Kallala

typo, PUMP_ON_STATE

typo, PUMP_ON_STATE

Tuesday 10 Mar
11:48 am

Dara Navaei

LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list
LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Wednesday 04 Mar
12:46 pm

Dara Navaei

12:46 pm

Dara Navaei

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Monday 09 Feb
4:49 pm

Zoltan Miskolci

1:47 pm

Sean Nash

9:16 am

Michael Garthwaite

This class member is a way for dialin to present all the valve states in a list like so: >>> fp = FP() >>> fp.valves.valve_states_enum [0, 0, 0, 0, 0, 0, 0] It is organized in the order of the e...

This class member is a way for dialin to present all the valve states in a list like so:

>>> fp = FP()
>>> fp.valves.valve_states_enum
[0, 0, 0, 0, 0, 0, 0]


It is organized in the order of the enum that was used to iterate. This is purely for presentation / Quality of life feature for the dialin user. We can remove it if we know users are no longer using it for monitoring

Friday 06 Feb
2:14 pm

Sean Nash

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

9:47 am

Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

9:45 am

Zoltan Miskolci

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

9:30 am

Sean Nash

Is this a dynamic enum?

Is this a dynamic enum?

9:29 am

Sean Nash

What is happening here? Is this a dynamic enum? Where is it used?

What is happening here? Is this a dynamic enum? Where is it used?

9:11 am

Zoltan Miskolci

Thursday 05 Feb
10:49 am

Michael Garthwaite

10:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2994_IOFP valve data is inaccurate
LEAHI-DIALIN-LDT-2994_IOFP valve data is inaccurate
Monday 26 Jan
4:51 pm

Zoltan Miskolci