leahi-fwcommon

PIControllers.c

Clone Tools

Stats

Commits this week: 6
Total Committers: 6
Last Commit: 20:50
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
55 mins ago

Vendor - TEL - Sameer Poyil

LDT-2004 Dry bicarb closed loop tuning

Options
    • -2
    • +2
    /PIControllers.c
13 hrs ago

Vendor - TEL - Sameer Poyil

LDT-2004 dry bicarb and acid closed loop control

Options
    • -0
    • +44
    /PIControllers.c
  2. … 1 more file in changeset.
Wednesday 25 Mar
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Saturday 21 Mar
7:56 am

Vendor - TEL - Sameer Poyil

I do not see TD use case in any of the PI controller functions. so why TD for this function ?

I do not see TD use case in any of the PI controller functions. so why TD for this function ?

Friday 20 Mar
11:48 am

Vinayakam Mani

LDT-3352 heater control update

Options
    • -5
    • +44
    /PIControllers.c
11:39 am

Vinayakam Mani

LDT-3352 dialysate temp control update

Options
    • -5
    • +3
    /PIControllers.c
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?

12:55 pm

Sean Nash

This is a structure, not an enumeration.

This is a structure, not an enumeration.

Monday 16 Mar
2:18 pm

Michael Garthwaite

LDT-3218: updated step limit for ro pump

Options
    • -1
    • +1
    /PIControllers.c
11:10 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Friday 13 Mar
9:33 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

9:24 am

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

9:16 am

Sean Nash

Remove blank line.

Remove blank line.

Thursday 12 Mar
3:43 pm

Vinayakam Mani

Done.

Done.

3:42 pm

Vinayakam Mani

Done.

Done.

3:41 pm

Vinayakam Mani

LDT-3352 heater control update

Options
    • -4
    • +45
    /PIControllers.c
  2. … 1 more file in changeset.
Friday 06 Mar
1:29 pm

Michael Garthwaite

LDT-3218: updated step limit for RO flow control

Options
    • -1
    • +1
    /PIControllers.c
Wednesday 25 Feb
12:49 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?

12:48 pm

Vendor - TEL - Sameer Poyil

mis aligned ?

mis aligned ?