leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

This is to avoid compilation warning

This is to avoid compilation warning

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

What is this?

What is this?

Add blank line after declarations.

Add blank line after declarations.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

else TD ?

else TD ?

This is a structure, not an enumeration.

This is a structure, not an enumeration.

Merge branch 'LDT-3218-update-iofp-permeate-target-flow' into develop

LDT-3218: updated step limit for ro pump

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Merge branch 'LDT-2004-v2-conductivity-sensors' into develop

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow

Merge branch 'staging' into LDT-2004-v2-conductivity-sensors

Merge remote-tracking branch 'origin/staging' into staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'staging' of bitbucket.org:diality-cloud/leahi-fwcommon into staging

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Can we remove the empty lines after if / else if blocks in this function?

Can we remove the empty lines after if / else if blocks in this function?

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
done changed it.

done changed it.

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.