BalancingChamber.c

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

This is to avoid compilation warning

This is to avoid compilation warning

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

What is this?

What is this?

Add blank line after declarations.

Add blank line after declarations.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

else TD ?

else TD ?

This is a structure, not an enumeration.

This is a structure, not an enumeration.

LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
done changed it.

done changed it.

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

changed

changed

removed from everywhere

removed from everywhere

removed

removed

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

updated.

updated.

done.

done.

done

done

changed accordingly.

changed accordingly.

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

align

align

align

align