dd-firmware / firmware / App / Services

Messaging.c

Clone Tools

Stats

Commits this week: 7
Total Committers: 13
Last Commit: 19 Mar
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
3:37 pm

Vendor - TEL - Sameer Poyil

LDT-2004 closed loop implementation

Options
    • -0
    • +6
    ./Messaging.c
  2. … 4 more files in changeset.
11:15 am

Michael Garthwaite

Merge branch 'LDT-3777-sprint-25-fixes' into develop

Options
    • -2
    • +2
    ./Messaging.c
  2. … 1 more file in changeset.
10:58 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Messaging.c
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

6:58 pm

Dara Navaei

Merged staging and resolved the conflicts

Options
    • -12
    • +0
    ./Messaging.c
  2. … 10 more files in changeset.
2:30 pm

Sean Nash and Michael Garthwaite

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?

12:55 pm

Sean Nash

This is a structure, not an enumeration.

This is a structure, not an enumeration.

Tuesday 17 Mar
7:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
Monday 16 Mar
11:10 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
11:01 am

Michael Garthwaite

Merge branch 'LDT-2004-v2-conductivity-sensors' into develop

Options
    • -17
    • +10
    ./Messaging.c
  2. … 5 more files in changeset.
Thursday 12 Mar
1:52 pm

Michael Garthwaite

LDT-2004: override fixes for v1 and v2 sensors.

Options
    • -15
    • +8
    ./Messaging.c
  2. … 5 more files in changeset.
7:21 am

Raghu Kallala

That's a question for me, will that be required? Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required) Init don't have any and service is not defined yet

That's a question for me, will that be required?

Fault has sub modes(3), Standby has 1 sub mode(I am adding code for this as this might be required)
Init don't have any and service is not defined yet

6:37 am

Raghu Kallala

Updated

Updated

6:37 am

Raghu Kallala

Updated

Updated

6:36 am

Raghu Kallala

Changed and left them as static, as we don't need these outside this unit

Changed and left them as static, as we don't need these outside this unit

6:27 am

Raghu Kallala

You are right, (missed that while duplicating the functions)

You are right, (missed that while duplicating the functions)

Wednesday 11 Mar
2:37 pm

Sean Nash

if ( TRUE == result )

if ( TRUE == result )

2:34 pm

Sean Nash

Since both states require no special handling, remove breaks and group with default - all modes.

Since both states require no special handling, remove breaks and group with default - all modes.

2:34 pm

Sean Nash

Remove comment.

Remove comment.

2:31 pm

Sean Nash

Add comment that all of these states require no special handling.

Add comment that all of these states require no special handling.

2:27 pm

Sean Nash

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

I think these functions (validate and signal) should be "test" functions and moved down to Dialin test functions section below - for all modes.

2:25 pm

Sean Nash

Add comment that no action is required for these modes - defaulting to invalid request.

Add comment that no action is required for these modes - defaulting to invalid request.