TxParams.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
will create a branch for dialin and make the necessary changes. Before merging will talk to Caitlynn to change the variable in automated testing as well.

will create a branch for dialin and make the necessary changes. Before merging will talk to Caitlynn to change the variable in automated testing as well.

Remove empty line

Remove empty line

Please sync this payload in DD firmware, Leahi-dialin and System Scripts.

Please sync this payload in DD firmware, Leahi-dialin and System Scripts.

Align the indent

Align the indent

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 8 more files in changeset.
currentInstallState is an input.

currentInstallState is an input.

Do we need doxygen comments for static function declarations? We will have a header in the definition.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

AirPump.h should be above AirTrap.h

AirPump.h should be above AirTrap.h

LDT-4028:Addresses Review Comments for Install State

  1. … 2 more files in changeset.
Remove extra ;

Remove extra ;

Can we align comments?

Can we align comments?

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

Remove this blank line.

Remove this blank line.

LDT-4028:Addressed code review commens for Pre-Tx Install State

  1. … 8 more files in changeset.
please add message id.

please add message id.

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.