dd-firmware / firmware / App / Services

Messaging.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 10 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Dec
10:18 am

Michael Garthwaite

Tuesday 16 Dec
1:25 pm

Vendor - TEL - Sameer Poyil

marking it as resolved since it is temporary driver

marking it as resolved since it is temporary driver

11:51 am

Vendor - TEL - Sameer Poyil

As per Sean's comment mark it as resolved

As per Sean's comment mark it as resolved

11:48 am

Vendor - TEL - Sameer Poyil

marking it as resolved since this is a temporary driver

marking it as resolved since this is a temporary driver

11:48 am

Vendor - TEL - Sameer Poyil

I am marking it as resolved since it is temporary driver

I am marking it as resolved since it is temporary driver

11:45 am

Vendor - TEL - Sameer Poyil

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

Its like we need to compile the safe library and include it. But if we are using only memcpy and memset, memcmp and static code analyzer check the destination buffer size , I am marking it as resolved

Monday 15 Dec
2:27 pm

Sean Nash

This function has an output.

This function has an output.

2:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

Friday 12 Dec
9:22 am

Vendor - TEL - Sameer Poyil and Sean Nash

Thursday 11 Dec
2:00 pm

Sean Nash

Is this temporary? If so, put a TODO to remove later.

Is this temporary? If so, put a TODO to remove later.

1:59 pm

Sean Nash

Remove extra spaces between { and msg name.

Remove extra spaces between { and msg name.

1:58 pm

Sean Nash

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC e...

Is this always needed or is it only needed in one or more specific modes (i.e. gen dialysate mode)? If only needed in specific modes, I think this should be called from those modes (similar to BC exec).

1:56 pm

Sean Nash

Do these belong in the spent chamber fill group?

Do these belong in the spent chamber fill group?

10:17 am

Vendor - TEL - Jashwant Gantyada

I think you are seeing previous commit. It is not there in the present code.

I think you are seeing previous commit. It is not there in the present code.

10:16 am

Vendor - TEL - Jashwant Gantyada

Done. Thank you.

Done. Thank you.

10:15 am

Vendor - TEL - Jashwant Gantyada

Changed. Thank you.

Changed. Thank you.

Wednesday 10 Dec
8:03 pm

Vendor - TEL - Sameer Poyil

is it merge issue ?

is it merge issue ?

7:56 pm

Vendor - TEL - Sameer Poyil

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

If it is not used for serial message, its OK, but if you are opting for packing , club it together , in line number 36 , or bring that structure defined on top to here

7:50 pm

Vendor - TEL - Sameer Poyil

Please bring public functions on top. check it for all function in this file , except test functions

Please bring public functions on top. check it for all function in this file , except test functions

Tuesday 09 Dec
11:25 am

Raghu Kallala

11:24 am

Dara Navaei

11:21 am

Dara Navaei

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

Vendor - TEL - Sameer Poyil this structure is not used to message handling.

11:20 am

Sean Nash and Vendor - TEL - Sameer Poyil

11:19 am

Dara Navaei

11:15 am

Dara Navaei

Done

Done

11:12 am

Vendor - TEL - Sameer Poyil

comments should start with capital letter

comments should start with capital letter

10:43 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:39 am

Sean Nash

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

Dara Navaei, this is not a CAN message payload, but it does look like a sensor serial message payload. I'm assuming this code works, so sensor does not expect a packed structure?

10:29 am

Raghu Kallala

Resolved

Resolved

10:27 am

Sean Nash

Shouldn't EVERY state set ALL valves?

Shouldn't EVERY state set ALL valves?