leahi-dialin / leahi_dialin / dd / modules

gen_dialysate.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 03 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Monday 09 Feb
11:48 am

Zoltan Miskolci

11:38 am

Raghu Kallala , Michael Garthwaite and Sean Nash

Friday 06 Feb
9:17 am

Zoltan Miskolci

Monday 26 Jan
4:51 pm

Zoltan Miskolci

4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Friday 23 Jan
3:18 pm

Michael Garthwaite

Thursday 22 Jan
10:07 am

Zoltan Miskolci

Wednesday 21 Jan
12:35 pm

Sean Nash

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

Monday 12 Jan
5:08 pm

Zoltan Miskolci

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

1:04 pm

Sean Nash

Why move this here? Seems like an odd placement so far away from D14.

Why move this here? Seems like an odd placement so far away from D14.

Thursday 08 Jan
10:33 am

Zoltan Miskolci

Merged FP into DD test configs

Merged FP into DD test configs

10:33 am

Zoltan Miskolci

Renamed

Renamed

9:34 am

Zoltan Miskolci

Fixed

Fixed

9:34 am

Zoltan Miskolci

Added enum to FP and TD Configs.

Added enum to FP and TD Configs.

9:28 am

Zoltan Miskolci

Vinayakam Mani What is the advantage of doing that? If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository wh...

Vinayakam Mani What is the advantage of doing that?
If I go with Beta_1_9_HW, I will need to rename the flag when we start using Beta 2+. And rename it in all the scripts in different repository when starting with 2.0.
While I use a more generic flag, I won't need to do that. So just using a better name I am sparing myself hours of work in the future.

Wednesday 07 Jan
11:47 am

Vinayakam Mani

You may use the same test configs from DD here, to set the relevant test configs from FP Dialin.

You may use the same test configs from DD here, to set the relevant test configs from FP Dialin.

11:35 am

Vinayakam Mani

POS_FIELD_3??

POS_FIELD_3??

11:34 am

Vinayakam Mani

Please follow the same naming convention as firmware enums.

Please follow the same naming convention as firmware enums.

Tuesday 06 Jan
4:33 pm

Dara Navaei

LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions
LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions
Monday 05 Jan
11:02 am

Sean Nash

Understand. In this case, the spare positions correspond to bit positions in the FPGA register and the new valves took the 1, 2, and 6 spots.

Understand. In this case, the spare positions correspond to bit positions in the FPGA register and the new valves took the 1, 2, and 6 spots.

11:01 am

Zoltan Miskolci

Fixed Typo

Fixed Typo

10:57 am

Zoltan Miskolci

Ok (But feels weird to start the counting of existing items from 0 if that's the spare3 instead of 1. Calling the D79 the "zeroeth" spare valve instead of the first spare valve... Personally I thin...

Ok
(But feels weird to start the counting of existing items from 0 if that's the spare3 instead of 1. Calling the D79 the "zeroeth" spare valve instead of the first spare valve... Personally I think we should name them Spare1-8 instead of Spare 0-7)

10:23 am

Sean Nash

In f/w, the spares are numbered 3, 4, 5, and 7 (not 1..4).

In f/w, the spares are numbered 3, 4, 5, and 7 (not 1..4).

10:20 am

Sean Nash

interval?

interval?