dd-firmware / firmware / App / Controllers

BalancingChamber.c

Clone Tools

Stats

Commits this week: 17
Total Committers: 8
Last Commit: 25 Mar
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 27 Mar
7:56 am

Vendor - TEL - Sameer Poyil

No, its deleted

No, its deleted

7:54 am

Vendor - TEL - Sameer Poyil

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

Wednesday 25 Mar
9:33 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 bug fixes and logic updates for pressure based flow rate

Options
    • -2
    • +7
    ./BalancingChamber.c
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Tuesday 24 Mar
7:59 pm

Vendor - TEL - Jashwant Gantyada

done

done

7:59 pm

Vendor - TEL - Jashwant Gantyada

done

done

7:58 pm

Vendor - TEL - Jashwant Gantyada

updated

updated

7:45 pm

Vendor - TEL - Jashwant Gantyada

LDT-2749 added the override function declaration for enabling venous bubble alarm in standby mode

Options
    • -85
    • +113
    ./BalancingChamber.c
3:42 pm

Vinayakam Mani

3:41 pm

Vinayakam Mani

the else part here, should handle greater than Qd: 300?

the else part here, should handle greater than Qd: 300?

3:38 pm

Vinayakam Mani

Get this logic into another function and call the function here.

Get this logic into another function and call the function here.

3:33 pm

Vinayakam Mani

Is this supposed to be difference in pressure, not the spent dial pressure?

Is this supposed to be difference in pressure, not the spent dial pressure?

2:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
11:59 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 code changes according to vinay's comments

Options
    • -87
    • +58
    ./BalancingChamber.c
10:39 am

Vendor - TEL - Jashwant Gantyada

LDT-3103 fixed logic for lower qds

Options
    • -3
    • +122
    ./BalancingChamber.c
Monday 23 Mar
10:30 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

5:37 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BalancingChamber.c
  2. … 5 more files in changeset.
5:35 pm

Dara Navaei

Merged LDT-3750

Options
    • -3
    • +25
    ./BalancingChamber.c
  2. … 1 more file in changeset.
4:47 pm

Dara Navaei

LDT-3750 updated the balancing chamber and concentrate pumps

Options
    • -1
    • +1
    ./BalancingChamber.c
  2. … 1 more file in changeset.
4:41 pm

Dara Navaei

LDT-3750 added math library

Options
    • -1
    • +1
    ./BalancingChamber.c
  2. … 1 more file in changeset.
3:37 pm

Dara Navaei

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?