leahi-fwcommon

TestSupport.h

Clone Tools

Stats

Commits this week: 11
Total Committers: 11
Last Commit: 10 Feb
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
6 hrs ago

Vinayakam Mani

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

For B1.0/B1.9 - Where Diener silencer 2000 pumps, this macro needs to be enabled.

6 hrs ago

Vinayakam Mani

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

There are recent changes done on FPGA register in staging for B1.0/B1.9. please merge the latest changes here.

6 hrs ago

Vinayakam Mani

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

Add valve details per HDD (may be 2.0 valves. as we remove beta 1/1.9 in sometime)

6 hrs ago

Vinayakam Mani

add new valves.

add new valves.

6 hrs ago

Vinayakam Mani

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

Can we follow the same terminology as DD, starting a variable with 'fpga...'. for all IOFP variables?

6 hrs ago

Vinayakam Mani

typo - used.

typo - used.

6 hrs ago

Vinayakam Mani

Add as HDF hallsensor. start the comment with capital letter R.

Add as HDF hallsensor. start the comment with capital letter R.

6 hrs ago

Vinayakam Mani

#define 0U across the file.

#define 0U across the file.

7 hrs ago

Vinayakam Mani

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we nee...

Instead of generic function, recommend adding a specific function something similar to "getACSwitchStatus' or 'getLeaskSensorStatus' and return the values ( ex: leak sensor Enum states?). Do we need to add the application code as well now, say if leak is found, trigger an alarm?

7 hrs ago

Vinayakam Mani

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

either typecast pwmInCount as U08 while passing to FPGA or declare the variable size as U08 instead of U32.

7 hrs ago

Vinayakam Mani

Add a variable to convert PWM count to target speed for monitor function.

Add a variable to convert PWM count to target speed for monitor function.

7 hrs ago

Michael Garthwaite

7 hrs ago

Vinayakam Mani

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

Please add 'execRinsePumpMonitor' which checks the commanded vs measured speed tolerance check and trigger alarm if deviates beyond the limit. You may move this function into monitor.

8 hrs ago

Vinayakam Mani

Use #define macros for magic numbers.

Use #define macros for magic numbers.

8 hrs ago

Sean Nash

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch o...

Do we need to code this controller for multiple rinse pumps? I guess we've done it in some of the others, so I'm not against doing it this way. But if we do, we need to validate pumpID in a bunch of functions and trigger a s/w fault if it's invalid.

8 hrs ago

Sean Nash

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

Are we only publishing the measured pump speed? Even then, we should probably calculate it prior to the switch statement above in case we start using it in the states.

9 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

9 hrs ago

Sean Nash

Add a TODO to comment then.

Add a TODO to comment then.

9 hrs ago

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

9 hrs ago

Raghu Kallala

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

This is a 4 byte reserved bits, not used at this time on Beta 1.9 or Beta 2.0

12 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

12 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

12 hrs ago

Vendor - TEL - Jashwant Gantyada

done.

done.

Wednesday 11 Feb
4:19 pm

Vendor - TEL - Sameer Poyil and Sean Nash

3:01 pm

Vinayakam Mani

Done.

Done.

2:49 pm

Vinayakam Mani

Updated.

Updated.

2:48 pm

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

2:39 pm

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

2:24 pm

Sean Nash

In °C?

In °C?

2:23 pm

Sean Nash

Is return value in °C? U32 is pretty low resolution for a temperature.

Is return value in °C? U32 is pretty low resolution for a temperature.