Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Updated

Updated

Does this string need to change as well?

Does this string need to change as well?

- Updated test configs - Updated valves

  1. … 2 more files in changeset.
LEAHI-DIALIN-LDT-3344_Firmware support for Beta 2 FPGA updates.
LEAHI-DIALIN-LDT-3344_Firmware support for Beta 2 FPGA updates.
Removed

Removed

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module
LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module
Removed D98_COND

  1. … 2 more files in changeset.
merged staging into dry bicart branch and code is pushed

merged staging into dry bicart branch and code is pushed

New code pushed

New code pushed

Merging branch staging into LDT-2004-dry-bicart---dd

  1. … 3 more files in changeset.
Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place Broadcast -> cmd_generic_broadcast_interval_override others -> cmd_generic_ov...

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

This is not the code that is currently on staging, so I think you need to update it from there

This is not the code that is currently on staging, so I think you need to update it from there

fixed it

fixed it

This is a change from Zoltan and I am updated that into my local branch

This is a change from Zoltan and I am updated that into my local branch

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara