dd-firmware

Clone Tools

Stats

Commits this week: 46
Total Committers: 15
Last Commit: 04 Mar
Commits this week: 46

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
25 mins ago

Vendor - TEL - Sameer Poyil

All comments should start with capital letter

All comments should start with capital letter

39 mins ago

Vendor - TEL - Sameer Poyil

comment alignment issue

comment alignment issue

39 mins ago

Vendor - TEL - Sameer Poyil

it should be mentioned what function is used for calculating the equation.

it should be mentioned what function is used for calculating the equation.

46 mins ago

Vendor - TEL - Sameer Poyil

above comment applicable here .

above comment applicable here .

47 mins ago

Vendor - TEL - Sameer Poyil

if sensor id is not in the finite state enum value , it return 0 and here it calculate for P9

if sensor id is not in the finite state enum value , it return 0 and here it calculate for P9

55 mins ago

Vendor - TEL - Sameer Poyil

parameter is sensorId, not sensor

parameter is sensorId, not sensor

3 hrs ago

Dara Navaei

3 hrs ago

Vendor - TEL - Jashwant Gantyada and Sean Nash

3 hrs ago

Dara Navaei

5 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3605_(DD) BLD sensor intermittently does not read for B2.0 HW
LEAHI-DD-FIRMWARE-LDT-3605_(DD) BLD sensor intermittently does not read for B2.0 HW
6 hrs ago

Sean Nash

6 hrs ago

Sean Nash

Add default. What should we do if caller passed invalid sensor ID?

Add default. What should we do if caller passed invalid sensor ID?

10 hrs ago

Michael Garthwaite

updated newCondModel to be a U32 before check then casted to enum after. Note: Calculate conductivity has a default statement that will catch any value that is outside of the model enum ( and execu...

updated newCondModel to be a U32 before check then casted to enum after. Note: Calculate conductivity has a default statement that will catch any value that is outside of the model enum ( and execute standard conductivity model )

Wednesday 04 Mar
2:13 pm

Vendor - TEL - Sameer Poyil

Then need to add a default case in that function

Then need to add a default case in that function

2:10 pm

Vendor - TEL - Sameer Poyil

If all enumeration constants are non-negative and fit within the range of an int or unsigned int, the compiler has the flexibility to choose either a signed or unsigned type. In many common impleme...

If all enumeration constants are non-negative and fit within the range of an int or unsigned int, the compiler has the flexibility to choose either a signed or unsigned type. In many common implementations, it defaults to a signed int

2:05 pm

Sean Nash

Looked better before - now misspelled.

Looked better before - now misspelled.

2:04 pm

Sean Nash

0.0F

0.0F

2:04 pm

Sean Nash

indent looks 1 space off.

indent looks 1 space off.

2:01 pm

Sean Nash

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

If we include math, I like to see comment explaining what we're doing with it. Why remove it?

2:00 pm

Sean Nash

Declare at top of scope, assign down here if needed.

Declare at top of scope, assign down here if needed.

1:59 pm

Sean Nash

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

If there is only one target temperature, why are we passing in a heater ID to function? This seems weird to me having both heaters share a target.

1:57 pm

Sean Nash

Remove blank line.

Remove blank line.

1:56 pm

Sean Nash

Which heater does single target temp apply to? Or does same target apply to both heaters?

Which heater does single target temp apply to? Or does same target apply to both heaters?

1:53 pm

Sean Nash

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

I don't see ufVolumeperIteration being set in this function - why did you add it to Outputs?

1:51 pm

Sean Nash

Remove blank line.

Remove blank line.

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:51 pm

Sean Nash

Why 2 Inputs?

Why 2 Inputs?

1:51 pm

Sean Nash

return should be "none"

return should be "none"

1:50 pm

Sean Nash

return should be "none"

return should be "none"

1:49 pm

Sean Nash

Why 2 inputs?

Why 2 inputs?