leahi-dialin / leahi_dialin / common

dd_defs.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 01 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 02 Jun
9:46 am

Zoltan Miskolci

Add type definition for can_interface.

Add type definition for can_interface.

9:46 am

Zoltan Miskolci

Please update this section to reflect the latest structural changes merged to staging.

Please update this section to reflect the latest structural changes merged to staging.

9:45 am

Zoltan Miskolci

Please update this section to reflect the latest structural changes merged to staging.

Please update this section to reflect the latest structural changes merged to staging.

9:44 am

Zoltan Miskolci

Please move it before the DDValveStates to keep the order, so it will be easier to find it

Please move it before the DDValveStates to keep the order, so it will be easier to find it

9:43 am

Zoltan Miskolci

Please move it to the "Names" section. Preferably between DDPressureSensorNames and DDTemperatureSensorNames.

Please move it to the "Names" section. Preferably between DDPressureSensorNames and DDTemperatureSensorNames.

9:41 am

Zoltan Miskolci

That location is in used on the staging @ leahi-common. MSG_ID_FFU_SIGNAL_TD_UPDATE_AVAILABLE = 0xB3, ///< FFU signal TD update is available.

That location is in used on the staging @ leahi-common.

MSG_ID_FFU_SIGNAL_TD_UPDATE_AVAILABLE = 0xB3, ///< FFU signal TD update is available.

Monday 01 Jun
4:20 pm

Zoltan Miskolci

8:01 am

Raghu Kallala

Friday 29 May
10:05 am

Michael Garthwaite

Wednesday 27 May
1:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

10:19 am

Dara Navaei

LEAHI-DIALIN-LDT-4002_HDF - FW Implementation - 3/4:
LEAHI-DIALIN-LDT-4002_HDF - FW Implementation - 3/4:
Thursday 21 May
5:09 pm

Zoltan Miskolci

references to Denali has been removed

references to Denali has been removed

7:44 am

Raghu Kallala

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

Monday 04 May
5:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
Thursday 30 Apr
2:23 pm

Vendor - TEL - Sameer Poyil

Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

Friday 24 Apr
10:40 am

Zoltan Miskolci

Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Wednesday 22 Apr
11:48 am

Raghu Kallala and Michael Garthwaite

Friday 17 Apr
2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

12:05 pm

Dara Navaei

LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
Wednesday 08 Apr
11:26 am

Zoltan Miskolci

10:01 am

Michael Garthwaite and Raghu Kallala