leahi-common

Clone Tools

Stats

Commits this week: 23
Total Committers: 20
Last Commit: 20 May
Commits this week: 23

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
43 mins ago

Vendor - TEL - Arpita Srivastava

Added but crucible is not showing this change. Please check bitbucket.

Added but crucible is not showing this change. Please check bitbucket.

47 mins ago

Vendor - TEL - Arpita Srivastava

These variables are correctly initialized to the first enum in the list.

These variables are correctly initialized to the first enum in the list.

48 mins ago

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

49 mins ago

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

49 mins ago

Vendor - TEL - Arpita Srivastava

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

I would rather keep it. Anyways, we need an else block after else if, as per MISRA guidelines.

50 mins ago

Vendor - TEL - Arpita Srivastava

Not needed because the retry mechanism is going to be deleted in the next ticket.

Not needed because the retry mechanism is going to be deleted in the next ticket.

1 hr ago

Sean Nash

Why is this on a separate line? Move after = above.

Why is this on a separate line? Move after = above.

1 hr ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

1 hr ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

2 hrs ago

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
LEAHI-TD-FIRMWARE-LDT-4031_Pre-Treatment - FW Implementation - 6/6:
3 hrs ago

Vendor - TEL - Jashwant Gantyada

This was added by Vinay to force the chamber F filling.

This was added by Vinay to force the chamber F filling.

3 hrs ago

Vendor - TEL - Jashwant Gantyada

It was changed by Vinay as part of the Conductivity spikes issue.

It was changed by Vinay as part of the Conductivity spikes issue.

Sunday 26 Jul
8:37 pm

Sean Nash

Should this be the "Load Syringe" alarm that you just added?

Should this be the "Load Syringe" alarm that you just added?

10:01 am

Vendor - TEL - Sameer Poyil

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

This is a problem, when lower cart pressure, D80 closes and if it is not reached upper cart pressure, it won't open D80

9:56 am

Vendor - TEL - Sameer Poyil

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

Why do we need 1 minutes of D80 opening ? is it not filling withing 10 seconds ?

9:45 am

Vendor - TEL - Sameer Poyil

bicarbChamberLevel is a local variable and not an input

bicarbChamberLevel is a local variable and not an input

9:44 am

Vendor - TEL - Sameer Poyil

This is not required , we should design the state machine properly to handle chamber low level

This is not required , we should design the state machine properly to handle chamber low level

9:42 am

Vendor - TEL - Sameer Poyil

This is not the correct order for state machine,

This is not the correct order for state machine,

Saturday 25 Jul
10:00 pm

Sean Nash

Friday 24 Jul
4:46 pm

Sean Nash

4:37 pm

Sean Nash

Can't return in middle of function code.

Can't return in middle of function code.

4:29 pm

Sean Nash

Remove else and reject command in it and re-test.

Remove else and reject command in it and re-test.

10:11 am

Vinayakam Mani

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

At end of transition, do you want to initialize the totalSpentChamberFill reset to zero?

10:07 am

Vinayakam Mani

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

Could you use SpentChamberLevel here, instead calling the getLevelStatus function again? Same for next conditions check as well ( line:889)

9:32 am

Vinayakam Mani

Remove extra paranthesis.

Remove extra paranthesis.

9:29 am

Vinayakam Mani

Remove empty lines

Remove empty lines

9:28 am

Vinayakam Mani

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

Mention in comment this is equivalent to Qd:600 minus 50ms switching period to stabilize the valve closure.

9:24 am

Vinayakam Mani

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Update the comment for Spent chamber fill, max dialysate flow rate (Qd:600) used for fast filling.

Thursday 23 Jul
3:58 pm

Vinayakam Mani

3:39 pm

Vinayakam Mani

LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)
LEAHI-COMMON-LDT-5348_Reserve alarm IDs for development (from ID: 200 to 300)