Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Update the header docc please

Update the header docc please

DD Substitution Pump

DD Substitution Pump

It's not really a start / stop command, when you are setting the speed.

It's not really a start / stop command, when you are setting the speed.

shouldn't this be "msg_id_dd_substitution_pump_data"?

shouldn't this be "msg_id_dd_substitution_pump_data"?

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LDT-3984-unit-test-failure-fix

LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
LEAHI-DIALIN-LDT-4000_HDF - FW Implementation - 1/4:
LDT-4000: fixed unit testing

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

LEVEL_OFFSET?

LEVEL_OFFSET?

LDT-3984 fix for conductivie level sensors d46, d63,d98

  1. … 3 more files in changeset.
LDT-3984 conductive level sensor dialin implementation

  1. … 2 more files in changeset.
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LDT-3984 aligning D46 with DD firmware

  1. … 1 more file in changeset.
removed

removed

Remove this extra line

Remove this extra line

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

  1. … 60 more files in changeset.
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables