leahi-dialin / leahi_dialin / fp

modules

Clone Tools

Stats

Commits this week: 3
Total Committers: 8
Last Commit: 30 Apr
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Apr
2:23 pm

Vendor - TEL - Sameer Poyil

Wednesday 29 Apr
12:05 pm

Vendor - TEL - Sameer Poyil

LDT-3984 addressed review comments

Options
    • -1
    • +1
    ./levels.py
Tuesday 28 Apr
9:30 am

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

9:29 am

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

9:15 am

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

9:02 am

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

9:00 am

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

8:44 pm

Vendor - TEL - Sameer Poyil

LDT-3984 fix for conductivie level sensors d46, d63,d98

Options
    • -1
    • +3
    ./levels.py
  2. … 3 more files in changeset.
Sunday 26 Apr
2:46 pm

Sean Nash

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

Friday 24 Apr
10:45 pm

Vendor - TEL - Sameer Poyil

LDT-3984 conductive level sensor dialin implementation

Options
    • -3
    • +5
    ./levels.py
  2. … 2 more files in changeset.
Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Monday 30 Mar
2:33 pm

Zoltan Miskolci

11:30 am

Michael Garthwaite

9:39 am

Sean Nash

Thursday 26 Mar
12:16 pm

Dara Navaei

LEAHI-DIALIN-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DIALIN-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
11:16 am

Raghu Kallala

10:30 am

Zoltan Miskolci

Added

Added

6:32 am

Raghu Kallala

Add a TODO comment to change the message once implemented in FW

Add a TODO comment to change the message once implemented in FW

Monday 23 Mar
9:13 am

Zoltan Miskolci

Friday 20 Mar
2:07 pm

Zoltan Miskolci

removed duplicate

removed duplicate

2:04 pm

Raghu Kallala

ROPump is repeated

ROPump is repeated

1:56 pm

Raghu Kallala

RECOVERY_STATES

RECOVERY_STATES

1:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13
LEAHI-DIALIN-LDT-696_[TC Implement] LVTC-13
1:31 pm

Zoltan Miskolci

- Added RO recovery enum - Updated FP Pump state enums

Options
    • -1
    • +1
    ./boost_pump.py
    • -1
    • +1
    ./ro_pump.py
  3. … 4 more files in changeset.
Wednesday 18 Mar
1:27 pm

Michael Garthwaite and Raghu Kallala

Tuesday 17 Mar
7:05 am

Raghu Kallala

update params

update params

Monday 16 Mar
12:06 pm

Dara Navaei

LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list
LEAHI-DIALIN-LDT-3629_FP and DD valve_states_enum are one short of the full valve list
11:53 am

Zoltan Miskolci

renamed dict keys

Options
    • -3
    • +3
    ./valves.py
  2. … 2 more files in changeset.
10:06 am

Michael Garthwaite

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( ...

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).