ModeStandby.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

Align comment.

Align comment.

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

Should this line be un-commented?

Should this line be un-commented?

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 11 more files in changeset.
LEAHI-TD-FIRMWARE-LDT-4248_(TD) RO Loop Testing / Demo: TD pinch valves to be in the correct state at standby and treatment
LEAHI-TD-FIRMWARE-LDT-4248_(TD) RO Loop Testing / Demo: TD pinch valves to be in the correct state at standby and treatment
We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

We should just have 1 of these. Let's have TD always working in mL and mL/min, and we'll just convert before sending to UI or after receiving from UI.

we don't need pragma alignment on enums, could you exclude it ?

we don't need pragma alignment on enums, could you exclude it ?

Updated to ml/min, except for broadcast in treatment mode

Updated to ml/min, except for broadcast in treatment mode

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert ...

What TD does with UF rate is mostly to tell DD what rate we want. DD wants mL/min. TD can keep L/hr and convert to mL/min every time it needs to send DD a message or it can keep mL/min and convert to L/hr every time it needs to send UI a message. Either way works for me.

Changed to U32

Changed to U32

we are sending a message ack as response in the handler of this message request

we are sending a message ack as response in the handler of this message request

Other existing set functions in TD is using UF in liter and rate in L/hr Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

Other existing set functions in TD is using UF in liter and rate in L/hr

Shall I change all of them? Which might impact how systems is sending this info(L/hr or ml/min) in their scripts

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When se...

I think DD (and TD) want mL/min and UI wants L/hr. TxParams should have already calculated this rate (in mL/min) and should probably have a get function you can call from here to access it. When sending UF rate to UI, we would convert back to L/hr first, but everywhere else we would work with mL/min.

Remove extra blank line.

Remove extra blank line.

Remove extra space before function name.

Remove extra space before function name.

This is not a Dialin message, so move up above all of these "test" functions.

This is not a Dialin message, so move up above all of these "test" functions.