leahi-fwcommon

PIControllers.h

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 09:58
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 17 May
10:59 pm

Sean Nash

Should we set this flag to FALSE at top of loop?

Should we set this flag to FALSE at top of loop?

10:58 pm

Sean Nash

Should we just set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

10:50 pm

Sean Nash

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

10:47 pm

Sean Nash

Update comment.

Update comment.

10:46 pm

Sean Nash

Is this eventually going to be d1Temp?

Is this eventually going to be d1Temp?

Friday 08 May
9:21 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /PIControllers.h
  2. … 1 more file in changeset.
Wednesday 06 May
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
9:47 am

Vinayakam Mani

LDT-872 heater control update

Options
    • -0
    • +1
    /PIControllers.h
  2. … 1 more file in changeset.
Monday 20 Apr
8:17 am

Vendor - TEL - Sameer Poyil

Friday 17 Apr
9:54 am

Vinayakam Mani

Thursday 16 Apr
11:17 pm

Sean Nash and Vinayakam Mani

11:13 pm

Sean Nash

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
4:23 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
4:19 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /PIControllers.h
  2. … 2 more files in changeset.
4:15 pm

Vendor - TEL - Sameer Poyil

LDT-2004 merging staging branch to LDT-2004-dialysate-composition-dosing-control--dd

Options
    • -3
    • +4
    /PIControllers.h
  2. … 1 more file in changeset.
2:28 pm

Vendor - TEL - Sameer Poyil

Its static function and not used by external API to pass the wrong id.

Its static function and not used by external API to pass the wrong id.

Wednesday 15 Apr
9:34 pm

Vendor - TEL - Sameer Poyil

0.0F is made by Sean.

0.0F is made by Sean.

Tuesday 14 Apr
9:22 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /PIControllers.h
  2. … 1 more file in changeset.
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

7:28 pm

Vinayakam Mani

Same comment applies here (removing resetPIController).

Same comment applies here (removing resetPIController).

7:18 pm

Vinayakam Mani

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

I think we can remove the balancing chamber fill in progress check for Opening D80 valve, as this does not impact the balancing chamber fill process.

7:14 pm

Vinayakam Mani

Maintain space after and before parenthesis across the file.

Maintain space after and before parenthesis across the file.

7:11 pm

Vinayakam Mani

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across th...

Do we need to add another else statement and address an alarm if wrong mixId is passed? or Keep only else part instead of else if ( ACID_MIX_ID == mixID) check?? this change may be needed across the file.

7:02 pm

Vinayakam Mani

Remove this comment.

Remove this comment.

6:58 pm

Vinayakam Mani

You may use getF32OverrideValue for consistency (across the file).

You may use getF32OverrideValue for consistency (across the file).

6:51 pm

Vinayakam Mani

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

The resetPIController is already invoked in InitializePIController with the InitialControlSignal. Instead of 0.0F, pass the STD_BICARB_DOSING as initialControlSignal ( in InitializePIController)

6:21 pm

Vinayakam Mani

This is being repeated.

This is being repeated.

6:20 pm

Vinayakam Mani

Please add comment. if it is not being used, delete it.

Please add comment. if it is not being used, delete it.

6:19 pm

Vinayakam Mani

Can this be reused from ConcentratePumps.h?

Can this be reused from ConcentratePumps.h?

6:16 pm

Vinayakam Mani

Add a space after and before parenthesis.

Add a space after and before parenthesis.