MessagePayloads.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why are we commenting this out?

Why are we commenting this out?

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

Why are we ending air trap control here?

Why are we ending air trap control here?

Why is this commented out?

Why is this commented out?

Add one more blank line before test support banner.

Add one more blank line before test support banner.

Remove these blank lines.

Remove these blank lines.

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

close D80, D64, D14?

close D80, D64, D14?

D80 : open, D65: Close?

D80 : open, D65: Close?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 1 more file in changeset.
This isn't right. Look at staging for correct code.

This isn't right. Look at staging for correct code.

I'm seeing a lot of magic numbers. We should have #defines for these values.

I'm seeing a lot of magic numbers. We should have #defines for these values.

Add doxygen comments to right.

Add doxygen comments to right.

LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

removed

removed

updated

updated

updated

updated

updated

updated

removed

removed

Shouldn't this be in ModePostTreatment?

Shouldn't this be in ModePostTreatment?

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

void cmdStartDDDisinfection( DD_COMMAND_T disCmdType )

Update this to work for all standby states w/ switch statement on given "new" state.

Update this to work for all standby states w/ switch statement on given "new" state.

Why zeroes? Why not send TD version constants?

Why zeroes? Why not send TD version constants?