dd-firmware / firmware / App / Modes

ModePostGenDialysate.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 05 May
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
10 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Wednesday 22 Apr
10:57 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePostGenDialysate.c
  2. … 12 more files in changeset.
10:42 am

Raghu Kallala

LDT-3749 resolved merge conflict with staging

Options
    • -2
    • +5
    ./ModePostGenDialysate.c
  2. … 6 more files in changeset.
10:41 am

Raghu Kallala

9:55 am

Vinayakam Mani

Tuesday 21 Apr
2:17 pm

Sean Nash

8:34 am

Raghu Kallala

Updated

Updated

Tuesday 14 Apr
10:57 am

Vendor - TEL - Arpita Srivastava

Friday 10 Apr
11:52 am

Vinayakam Mani

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

The FP signals are not included in the DD-pre gen/Gen dialysate transition functions. They have handled separately in the TD Interface.

11:44 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePostGenDialysate.c
  2. … 9 more files in changeset.
11:38 am

Sean Nash and Vinayakam Mani

8:33 am

Raghu Kallala

LDT-3749 addressed review comments

Options
    • -1
    • +3
    ./ModePostGenDialysate.c
  2. … 5 more files in changeset.
8:21 am

Raghu Kallala

You are right, modified in all places

You are right, modified in all places

Wednesday 08 Apr
1:51 pm

Sean Nash

FALSE?

FALSE?

1:50 pm

Sean Nash

FALSE?

FALSE?

1:46 pm

Sean Nash

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

Should default be TRUE? If we are being asked to validate an jump to an invalid state, shouldn't we return FALSE?

1:44 pm

Sean Nash

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always ha...

Vinayakam Mani, how does that signal happen normally? In your example, when would DD signal FP when starting pre-gen mode? If that signal happened in pre-gen transition function, it would always happen regardless of how we got to pre-gen mode.

1:41 pm

Sean Nash

Add comment that these modes not (yet?) supported.

Add comment that these modes not (yet?) supported.

8:24 am

Dara Navaei

Tuesday 07 Apr
2:54 pm

Vinayakam Mani

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we imple...

Probably, we need to signal FP as well when there is a mode change happens. say, DD changes standby to pre-gen/Gen Dialysate mode, FP needs to transition to pre-gen / generate permeate (as we implemented in TD interface).

Monday 06 Apr
1:00 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
12:46 pm

Raghu Kallala

LDT-3749 initial structure for set operation sub mode request.

Options
    • -0
    • +56
    ./ModePostGenDialysate.c
  2. … 12 more files in changeset.
12:45 pm

Raghu Kallala

11:36 am

Vinayakam Mani

Balancing chamber switching control

Balancing chamber switching control

11:29 am

Vinayakam Mani

remove the space before false.

remove the space before false.

11:23 am

Vinayakam Mani

Remove blank line

Remove blank line

11:23 am

Vinayakam Mani

Remove blank line.

Remove blank line.

11:00 am

Sean Nash

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Tuesday 17 Mar
7:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem
LEAHI-DD-FIRMWARE-LDT-3749_Ability to set operation sub mode on DD subsystem