dd-firmware / firmware / App / Controllers

BalancingChamber.c

Clone Tools

Stats

Commits this week: 15
Total Committers: 11
Last Commit: 25 Jun
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
4 hrs ago

Sean Nash and Vinayakam Mani

9 hrs ago

Vendor - TEL - Jashwant Gantyada

10 hrs ago

Vinayakam Mani

Wednesday 01 Jul
9:08 pm

Vendor - TEL - Sameer Poyil

6:31 pm

Sean Nash

10:18 am

Vendor - TEL - Jashwant Gantyada

updated

updated

9:16 am

Sean Nash

balancingError is an input.

balancingError is an input.

Tuesday 30 Jun
4:15 pm

Vendor - TEL - Arpita Srivastava

Add previousHeaterState to input and output

Add previousHeaterState to input and output

4:13 pm

Vendor - TEL - Arpita Srivastava

add prevDryBicartState to input and output.

add prevDryBicartState to input and output.

4:11 pm

Vendor - TEL - Arpita Srivastava

Add prevBalChamberState to input and output

Add prevBalChamberState to input and output

4:09 pm

Vendor - TEL - Arpita Srivastava

Add isBalChamberSwitchingActive to input

Add isBalChamberSwitchingActive to input

3:56 pm

Sean Nash

yes

yes

3:56 pm

Sean Nash

yes

yes

3:55 pm

Sean Nash

yes

yes

2:40 pm

Vinayakam Mani

Align it with declration.

Align it with declration.

2:39 pm

Vinayakam Mani

Add comments.

Add comments.

Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:20 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

3:04 pm

Vinayakam Mani

Wednesday 24 Jun
4:54 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review comments

Options
    • -1
    • +1
    ./BalancingChamber.c
  2. … 6 more files in changeset.
2:53 pm

Vendor - TEL - Sameer Poyil

2:47 pm

Vinayakam Mani

Space after if.

Space after if.

2:45 pm

Vinayakam Mani

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

2:40 pm

Vinayakam Mani

remove empty space after d66pressure variable. or match the indent to previous statement.

remove empty space after d66pressure variable. or match the indent to previous statement.

2:36 pm

Vinayakam Mani

Add a TODO comment (remove later): this should be handled in IO/FP module.

Add a TODO comment (remove later): this should be handled in IO/FP module.

2:33 pm

Vinayakam Mani

Update comment.

Update comment.

2:32 pm

Vinayakam Mani

Add comment.

Add comment.