leahi-common

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress...

To make it exclusive operation. no previous request should be pending when a new operation is requested. So only one state machine is running at a time. otherwise, while chamber fill is in progress, anyone can request drain and both requests will be handled. even through new code run only one state machine at a time, this will ensure that only one request is submitted to drybicart

LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
LEAHI-COMMON-LDT-3323_Misc SW Enhancements - SW - 01 - BloodPrime-Rinseback - R&I
Not clear, why we are checking fill and supply request here?

Not clear, why we are checking fill and supply request here?

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

we should use the functions defined in testsupport.c/h -> getU32OverrideValue, getF32OverrideValue based on data type. this needs to be fixed throughout the file.

space after if. please fix it throughout the files.

space after if. please fix it throughout the files.

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation. Also, setting supply request should be ...

I guess, Fill and Drain are priority items than the Supply request, which means upon request of fill and drain, state machine should service that operation.

Also, setting supply request should be based on the level sensor later (there shouldn't be any default request -> currently supply is assigned)

Please introduce test config for drybicart selection.

Please introduce test config for drybicart selection.

LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
LEAHI-TD-FIRMWARE-LDT-1415_Pressures Monitoring - TD
Commented out already but I dont know why it is showing the same

Commented out already but I dont know why it is showing the same

It's still UI only. Shouldn't this be commented out before we merge?

It's still UI only. Shouldn't this be commented out before we merge?

Yes, updated

Yes, updated

Removed

Removed

Remove blank line.

Remove blank line.

Looks like this reverted back.

Looks like this reverted back.

Fixed it

Fixed it

Remove extra blank line.

Remove extra blank line.

It is your comment, so please resolve it.

It is your comment, so please resolve it.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It is replied by Vinay , there is no need to maintain two different rpm. so we can close this.

It will be fixed in Balancing chamber re-implementation

It will be fixed in Balancing chamber re-implementation

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

I would prefer to fix this in balancing chamber new algorithm implementation. That is why i didn't mark it as Unresolved.

input parameter not updated

input parameter not updated

input parameter is not updated

input parameter is not updated

input and output is not updated properly

input and output is not updated properly

structure packing required

structure packing required

fixed it

fixed it