dd-firmware / firmware / App / Controllers

Valves.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 13
Last Commit: 01 Aug
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Jul
7:17 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
Wednesday 29 Jul
11:27 am

Vendor - TEL - Santhoshkumar Reddy Alasandagutti

Revert "Merge branch 'develop' into LDT-5102-dd-concentrate-pumps-hardware-d"

This reverts commit f43d59af8e69ef1459bafe91873ce41cf63a4a75, reversing

changes made to 7f56f07660862bc62524c506699193a7e5f48f96.

Options
    • -13
    • +0
    ./Valves.c
  2. … 23 more files in changeset.
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
Wednesday 24 Jun
6:36 am

Raghu Kallala

Wednesday 06 May
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Friday 17 Apr
9:54 am

Vinayakam Mani

6:24 am

Vendor - TEL - Sameer Poyil

Merge branch LDT-2004-dialysate-composition-dosing-control--dd into develop

Options
    • -5
    • +6
    ./Valves.c
  2. … 7 more files in changeset.
Thursday 16 Apr
8:24 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./Valves.c
  2. … 5 more files in changeset.
8:15 am

Michael Garthwaite

Wednesday 15 Apr
5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -3
    • +4
    ./Valves.c
  2. … 3 more files in changeset.
Tuesday 14 Apr
7:47 pm

Sean Nash and Vendor - TEL - Sameer Poyil

2:08 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:07 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:05 pm

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

2:04 pm

Sean Nash

Lower case x

Lower case x

2:02 pm

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

11:16 am

Michael Garthwaite

Merge branch 'staging' into LDT-3218-update-iofp-permeate-target-flow-CLEAN

Options
    • -2
    • +33
    ./Valves.c
  2. … 3 more files in changeset.
Monday 13 Apr
2:58 pm

Vinayakam Mani

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

Yes, this needs to be corrected. I don't see any controller existing properties defining these min and max. Will discuss further with you on this.

12:00 pm

Vinayakam Mani

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

Since feedforward output is same as control signal output, checking control signal min and max seems to be correct.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:57 am

Vinayakam Mani

Reduced gain and testing in progress.

Reduced gain and testing in progress.

11:56 am

Vinayakam Mani

Done.

Done.