leahi-dialin / leahi_dialin

dd

Clone Tools

Stats

Commits this week: 15
Total Committers: 12
Last Commit: 09 Sep 25
Commits this week: 15

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 06 Feb
8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm

Vendor - TEL - Sameer Poyil

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

3:24 pm

Zoltan Miskolci and Sean Nash

2:14 pm

Sean Nash

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

10:41 am

Sean Nash

Add a blank line between functions.

Add a blank line between functions.

9:47 am

Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

9:45 am

Zoltan Miskolci

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

9:37 am

Sean Nash

Is this staying? Is all of above replacing this class?

Is this staying? Is all of above replacing this class?

9:30 am

Sean Nash

Is this a dynamic enum?

Is this a dynamic enum?

9:29 am

Sean Nash

What is happening here? Is this a dynamic enum? Where is it used?

What is happening here? Is this a dynamic enum? Where is it used?

9:27 am

Sean Nash

9:25 am

Zoltan Miskolci

We agreed to change back the enums into the static variation. Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic o...

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

9:17 am

Zoltan Miskolci

9:11 am

Zoltan Miskolci

Thursday 05 Feb
3:38 pm

Dara Navaei

Did we not decide to revert all the changes back and the redesign the whole concept again?

Did we not decide to revert all the changes back and the redesign the whole concept again?

3:35 pm

Behrouz NematiPour

2:21 pm

Michael Garthwaite

11:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
10:49 am

Michael Garthwaite

10:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2994_IOFP valve data is inaccurate
LEAHI-DIALIN-LDT-2994_IOFP valve data is inaccurate
Tuesday 03 Feb
3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:54 pm

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3:54 pm

Behrouz NematiPour

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

3:30 pm

Vendor - TEL - Sameer Poyil , Zoltan Miskolci and Michael Garthwaite

2:27 pm

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

2:25 pm

Zoltan Miskolci

removed commented out line

removed commented out line

2:21 pm

Dara Navaei

LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides
LEAHI-DIALIN-LDT-3222_Command to override all balancing chamber valves states should be the same priority as setting individual valve state overrides