BalancingChamber.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
done changed it.

done changed it.

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

changed

changed

removed from everywhere

removed from everywhere

removed

removed

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

updated.

updated.

done.

done.

done

done

changed accordingly.

changed accordingly.

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

align

align

align

align

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

comment should start with capital letter

comment should start with capital letter

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.