leahi-dialin / leahi_dialin / common

dd_defs.py

Clone Tools

Stats

Commits this week: 3
Total Committers: 8
Last Commit: 31 Dec 69
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

3 hrs ago

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

3 hrs ago

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

3 hrs ago

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

3 hrs ago

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

Friday 24 Apr
10:40 am

Zoltan Miskolci

Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Wednesday 22 Apr
11:48 am

Raghu Kallala and Michael Garthwaite

Friday 17 Apr
2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

2:28 pm

Vinayakam Mani

12:05 pm

Dara Navaei

LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
LEAHI-DIALIN-LDT-3352_DD - revisit D3 level control logic
Wednesday 08 Apr
11:26 am

Zoltan Miskolci

10:01 am

Michael Garthwaite and Raghu Kallala

9:48 am

Raghu Kallala

Typo, response

Typo, response

9:48 am

Raghu Kallala

Typo, response

Typo, response

9:47 am

Raghu Kallala

Fix the header

Fix the header

Tuesday 31 Mar
10:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
Monday 30 Mar
9:39 am

Sean Nash

Monday 16 Mar
10:06 am

Michael Garthwaite

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( ...

yeah its obsolete. This is an old branch that recently got synced with latest staging. It looks like the CR doesn't recognize the correct changes from staging. There should only be 1 file change ( conductivity sensors ).

Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Wednesday 04 Mar
12:46 pm

Dara Navaei

12:46 pm

Dara Navaei

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Friday 13 Feb
9:37 am

Vinayakam Mani