leahi-dialin / leahi_dialin

fp

Clone Tools

Stats

Commits this week: 14
Total Committers: 7
Last Commit: 31 Dec 69
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 09 Feb
4:49 pm

Zoltan Miskolci

4:20 pm

Sean Nash

1:47 pm

Sean Nash

11:48 am

Zoltan Miskolci

11:38 am

Raghu Kallala , Michael Garthwaite and Sean Nash

9:16 am

Michael Garthwaite

This class member is a way for dialin to present all the valve states in a list like so: >>> fp = FP() >>> fp.valves.valve_states_enum [0, 0, 0, 0, 0, 0, 0] It is organized in the order of the e...

This class member is a way for dialin to present all the valve states in a list like so:

>>> fp = FP()
>>> fp.valves.valve_states_enum
[0, 0, 0, 0, 0, 0, 0]


It is organized in the order of the enum that was used to iterate. This is purely for presentation / Quality of life feature for the dialin user. We can remove it if we know users are no longer using it for monitoring

Friday 06 Feb
2:14 pm

Sean Nash

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

9:47 am

Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

9:45 am

Zoltan Miskolci

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

I don't think it's an enum at all. It was a list, but it was never updated, so I added that part to it.

9:30 am

Sean Nash

Is this a dynamic enum?

Is this a dynamic enum?

9:29 am

Sean Nash

What is happening here? Is this a dynamic enum? Where is it used?

What is happening here? Is this a dynamic enum? Where is it used?

9:17 am

Zoltan Miskolci

9:11 am

Zoltan Miskolci

Thursday 05 Feb
11:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
10:49 am

Michael Garthwaite

10:02 am

Dara Navaei

LEAHI-DIALIN-LDT-2994_IOFP valve data is inaccurate
LEAHI-DIALIN-LDT-2994_IOFP valve data is inaccurate
Monday 26 Jan
4:51 pm

Zoltan Miskolci

4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Friday 23 Jan
3:18 pm

Michael Garthwaite

3:18 pm

Zoltan Miskolci

-Fixed valve broadcast update - Fixed Beta 1.0 enums

Options
    • -1
    • +2
    ./modules/valves.py
  2. … 2 more files in changeset.
11:42 am

Zoltan Miskolci

- Removed HW flag from broadcast as FW doesn't change broadcast content based on HW flag

Options
    • -7
    • +4
    ./modules/pressure_sensors.py
    • -4
    • +3
    ./modules/temperatures.py
  3. … 5 more files in changeset.
Thursday 22 Jan
1:57 pm

Zoltan Miskolci

- Added D85 Valve - Removed error message during init as it's not an error

Options
    • -1
    • +1
    ./__init__.py
  2. … 6 more files in changeset.
10:07 am

Zoltan Miskolci

10:06 am

Zoltan Miskolci

Merge branch 'LDT-3214-override-refactor' into staging

Options
    • -111
    • +68
    ./filtration_purification.py
    • -41
    • +81
    ./modules/alarms.py
    • -123
    • +56
    ./modules/boost_pump.py
    • -100
    • +48
    ./modules/conductivity_sensors.py
    • -11
    • +15
    ./modules/events.py
    • -82
    • +59
    ./modules/flow_sensors.py
    • -75
    • +42
    ./modules/fp_test_configs.py
    • -47
    • +28
    ./modules/levels.py
    • -75
    • +40
    ./modules/pressure_sensors.py
    • -118
    • +55
    ./modules/ro_pump.py
    • -55
    • +27
    ./modules/temperatures.py
    • -102
    • +72
    ./modules/valves.py
    • -71
    • +40
    ./modules/water_pumps.py
  14. … 34 more files in changeset.
Wednesday 21 Jan
12:39 pm

Zoltan Miskolci

12:38 pm

Zoltan Miskolci

Merge branch 'LDT-3159-getter_for_fp_defeatured' into staging

Options
    • -14
    • +61
    ./filtration_purification.py
  2. … 1 more file in changeset.
12:35 pm

Sean Nash

12:32 pm

Sean Nash and Raghu Kallala

12:22 pm

Zoltan Miskolci

12:22 pm

Zoltan Miskolci

Merge branch 'LDT-2980' into staging

Options
    • -1
    • +1
    ./modules/temperatures.py