permeate_tank.py

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

Putting the aliases at the end makes them grouped up and in my opinion makes easier reading of the enum.

Why move this here? Seems like an odd placement so far away from D14.

Why move this here? Seems like an odd placement so far away from D14.

-Renamed DDConductivitySensorsEnum to DDConductivitySensorNames - Updated overrides in FP Module - Updated offset calculations in FP_Defs

  1. … 17 more files in changeset.
LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions
LEAHI-DIALIN-LDT-3214_[Leahi-Dialin] Refactor to use the generic override functions
LDT-2300: Resolved code review comments

  1. … 40 more files in changeset.
Done - timestamps added to DD, FP, and TD

Done - timestamps added to DD, FP, and TD

Done

Done

Done

Done

Done

Done

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only...

I'm not sure I really understand the question here, but I do know that the DD Heaters data is being published with this handler: I've organized all heater data into a nested dictionary so that only one "variable" is being published. The same goes for the other publish functions before each handler. I will reorganize the order of the published variables so that timestamp is listed last.

No timestamp?

No timestamp?

I didn't see dbg variables in the publish list above.

I didn't see dbg variables in the publish list above.

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere. Also, I think we typically list the timestamp ...

Is msg_id_dd_heaters_data really being published here? Should it be? ** This comment applies to all classes as it appears you've done this everywhere.
Also, I think we typically list the timestamp last.

Replace "dg" with "dd".

Replace "dg" with "dd".

Replace "hd" with "dd".

Replace "hd" with "dd".

LDT-2300: Added message ID to each observer

  1. … 40 more files in changeset.
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
LEAHI-DIALIN-LDT-2300_Dialin: Add a way for a Dialin user to identify what broadcast message is being received
Why so much white space?

Why so much white space?

???

???

Where is 0x5B?

Where is 0x5B?