leahi-dialin / leahi_dialin

fp

Clone Tools

Stats

Commits this week: 2
Total Committers: 8
Last Commit: 31 Dec 69
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Zoltan Miskolci

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

2 hrs ago

Zoltan Miskolci

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.

2 hrs ago

Zoltan Miskolci

Why increment the number when you didn't add a new sensor?

Why increment the number when you didn't add a new sensor?

2 hrs ago

Raghu Kallala

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

This should be LAST_DD_LEVL not NUM_OF_LEVELS if DD and FP levels are in same enum

2 hrs ago

Raghu Kallala

LEVEL_OFFSET?

LEVEL_OFFSET?

Monday 27 Apr
8:46 pm

Sean Nash and Raghu Kallala

Sunday 26 Apr
2:46 pm

Sean Nash

Should this be an enumeration somewhere?

Should this be an enumeration somewhere?

Thursday 23 Apr
8:02 am

Dara Navaei

LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
Friday 10 Apr
10:20 am

Zoltan Miskolci

Thursday 09 Apr
3:20 pm

Raghu Kallala and Michael Garthwaite

3:03 pm

Zoltan Miskolci

-Added TD test config - Updated fp get requests based on latest change in FW

Options
    • -9
    • +8
    ./filtration_purification.py
  2. … 1 more file in changeset.
3:00 pm

Dara Navaei

LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
LEAHI-DIALIN-LDT-3910_Request: add TD config flag so that alarms originating from other subsystems don't put the TD into fault mode
Wednesday 08 Apr
11:26 am

Zoltan Miskolci

10:01 am

Michael Garthwaite and Raghu Kallala

9:52 am

Zoltan Miskolci

CR fixes

Options
    • -3
    • +3
    ./filtration_purification.py
9:48 am

Raghu Kallala

Typo, response

Typo, response

9:48 am

Raghu Kallala

Typo, response

Typo, response

9:47 am

Raghu Kallala

Fix the header

Fix the header

Thursday 02 Apr
11:13 am

Zoltan Miskolci

enum updates

Options
    • -7
    • +6
    ./filtration_purification.py
  2. … 10 more files in changeset.
Tuesday 31 Mar
10:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
LEAHI-DIALIN-LDT-3824_[Leahi-TestCommon] Enhance state machine
Monday 30 Mar
2:33 pm

Zoltan Miskolci

11:30 am

Michael Garthwaite

9:39 am

Sean Nash

Thursday 26 Mar
12:16 pm

Dara Navaei

LEAHI-DIALIN-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DIALIN-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
11:16 am

Raghu Kallala

10:31 am

Zoltan Miskolci

moved comment

Options
    • -2
    • +1
    ./filtration_purification.py
10:30 am

Zoltan Miskolci

Added

Added

10:29 am

Zoltan Miskolci

Added todo comments

Options
    • -4
    • +5
    ./filtration_purification.py
6:32 am

Raghu Kallala

Add a TODO comment to change the message once implemented in FW

Add a TODO comment to change the message once implemented in FW

Wednesday 25 Mar
3:20 pm

Zoltan Miskolci

- Fixes fp pump status enums - P40 template

Options
    • -13
    • +48
    ./filtration_purification.py
  2. … 1 more file in changeset.