Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add type definition for can_interface.

Add type definition for can_interface.

Please update this section to reflect the latest structural changes merged to staging.

Please update this section to reflect the latest structural changes merged to staging.

Please update this section to reflect the latest structural changes merged to staging.

Please update this section to reflect the latest structural changes merged to staging.

Please move it before the DDValveStates to keep the order, so it will be easier to find it

Please move it before the DDValveStates to keep the order, so it will be easier to find it

Please move it to the "Names" section. Preferably between DDPressureSensorNames and DDTemperatureSensorNames.

Please move it to the "Names" section. Preferably between DDPressureSensorNames and DDTemperatureSensorNames.

That location is in used on the staging @ leahi-common. MSG_ID_FFU_SIGNAL_TD_UPDATE_AVAILABLE = 0xB3, ///< FFU signal TD update is available.

That location is in used on the staging @ leahi-common.

MSG_ID_FFU_SIGNAL_TD_UPDATE_AVAILABLE = 0xB3, ///< FFU signal TD update is available.

Please update this section based on the newest staging. If you try to merge it like this it will cause inconsistencies.

Please update this section based on the newest staging. If you try to merge it like this it will cause inconsistencies.

I would like to ask to check out the substitution pump on the develop branch and update it based on that. There are some changes thanks to the merging of the refactor.

I would like to ask to check out the substitution pump on the develop branch and update it based on that.
There are some changes thanks to the merging of the refactor.

fix the typo.

fix the typo.

Delta instead of target conductivity?

Delta instead of target conductivity?

looks there are some more payloads in publish function. please add the other parameters here.

looks there are some more payloads in publish function. please add the other parameters here.

LEAHI-DIALIN-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DIALIN-LDT-4001_HDF - FW Implementation - 2/4:
Remove extra blank line.

Remove extra blank line.

LEAHI-DIALIN-LDT-4002_HDF - FW Implementation - 3/4:
LEAHI-DIALIN-LDT-4002_HDF - FW Implementation - 3/4:
references to Denali has been removed

references to Denali has been removed

LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
LEAHI-DIALIN-LDT-2004_Dialysate Composition - DD
Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

LEAHI-DIALIN-LDT-3854_(DD) Chamber F level sensor not reporting the level properly
LEAHI-DIALIN-LDT-3854_(DD) Chamber F level sensor not reporting the level properly
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
LEAHI-DIALIN-LDT-3984_(DD, SW) D46 reads 0 with and without liquid in chamber
What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.

LAST_DD_LEVL is in FW not in dialin. In dialin, you use the Num_of_levels, so this one is correct here. Example: In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the...

LAST_DD_LEVL is in FW not in dialin.
In dialin, you use the Num_of_levels, so this one is correct here.
Example:
In this case Num_of_levels is 4 (D6,D63,D98,D46), if in the override adding 4 to the fp level sensor, which is 0, the payload will provide 4, which will be between the FIRST_FP_LEVL and LAST_FP_LEVL FW value as P25 index is 4.