Activity leahi-dialin/leahi_dialin/dd/modules/balancing

9:37 am

Vendor - TEL - Sameer Poyil , Sean Nash and Zoltan Miskolci

More
LEAHI-DIALIN-LDT-2004-1
finished reviewing

11:23 am

Vendor - TEL - Sameer Poyil

merged staging into dry bicart branch and code is pushed

11:22 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-2004-1
commented on review

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place Broadcast -> cmd_generic_broadcast_interval_override others -> cmd_generic_ov...

Could you update all the overrides to use the generic method? So we don't need to maintain these on more than one place
Broadcast -> cmd_generic_broadcast_interval_override
others -> cmd_generic_override

You can check any of the other modules how to use them

9:26 am

Zoltan Miskolci

This is not the code that is currently on staging, so I think you need to update it from there

8:57 pm

Vendor - TEL - Sameer Poyil

fixed it

5:55 pm

Vendor - TEL - Sameer Poyil

This is a change from Zoltan and I am updated that into my local branch

4:49 pm

Zoltan Miskolci

1:47 pm

Sean Nash

More
LEAHI-DIALIN-LDT-2994-3
finished reviewing

9:16 am

Michael Garthwaite

This class member is a way for dialin to present all the valve states in a list like so: >>> fp = FP() >>> fp.valves.valve_states_enum [0, 0, 0, 0, 0, 0, 0] It is organized in the order of the e...

This class member is a way for dialin to present all the valve states in a list like so:

>>> fp = FP()
>>> fp.valves.valve_states_enum
[0, 0, 0, 0, 0, 0, 0]

It is organized in the order of the enum that was used to iterate. This is purely for presentation / Quality of life feature for the dialin user. We can remove it if we know users are no longer using it for monitoring

8:18 pm

Vendor - TEL - Sameer Poyil

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by...

for Dry Bicart , I have reserved the message ID long time back as 0x70 and its correct. I was confused after staging branch merged with my local branch, since all of my other message ID are used by other modules except BICART_DATA. please dis regard this question.

8:15 pm

Vendor - TEL - Sameer Poyil

This is a merge issue. when I updated the code and aligned to staging , this all change happened. Need to check with Dara

2:14 pm

Sean Nash

Can you review this with Michael G and find out if this is even needed? Can we remove? If not, what is it doing and why?

10:41 am

Sean Nash

More
Re: LEAHI-DIALIN-LDT-2004-1
commented on review

Add a blank line between functions.

9:47 am

Zoltan Miskolci

I see it as a list, don't know why it is named enum or what the original purpose of it was. It was never updated, so I added the update part at least, so it will at least reflect the current states...

I see it as a list, don't know why it is named enum or what the original purpose of it was.
It was never updated, so I added the update part at least, so it will at least reflect the current states instead of always stating zeros.

9:45 am