•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-431-1 30 Dec 2019

Please, Please, Don't make codes unnecessarily long.
Your code is readable enough.
To see a function you have to scroll more than required.

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 06 Jan 2020

There is a lot of commented code that seems to be essential. Are you thinking of uncommenting them before merge? If so, we need to verify it.

HD-DEN-759-1 14 Nov 2019

Value "20", which is ...?

UI-DEN-1396-1 08 Jan 2020

Add space

DIALIN-1 26 Nov 2019

This is just test code. Any suggestion?

UI-DEN-1434-1 10 Mar 2020

RESOLVED.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-1090-1 30 Dec 2019

What I meant is vData += mPWMDtCycle.value; instead of vData += mPWMDtCycle .value;

such that the .value is always stuck to the member variable. This looks really odd as it stands.

HD-DEN-759-1 03 Dec 2019

Done.

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 27 Nov 2019

Done

HD-DEN-759-1 03 Dec 2019

Make this a constant you call here.

HD-DEN-759-1 04 Dec 2019

Done.

DIALIN-1 06 Dec 2019

RESOLVED.

HD-DEN-431-1 06 Jan 2020

Done!

DIALIN-1 06 Dec 2019

RESOLVED.

HD-DEN-759-1 03 Dec 2019

Some functions executed from a given task may want to know how often they are being called - so I provide this definition. From RTI registers I could get a clock divider value and somehow derive the timing from it, but that would be pretty complex as even those values depend on other general clock settings.

DIALIN-1 16 Dec 2019

RESOLVED.

UI-DEN-1090-1 30 Dec 2019
  • I aligned the m(s) so I'm sure that I'm using the correct variables since I have variables with the same name with v at the beginning most of the time.
  • Also it's really easy to copy/paste variables vertically.
  • Also it shows me at first look that I used ".value" otherwise it won't work.
UI-DEN-704-1 19 Dec 2019
DIALIN-1 05 Dec 2019

Is it our python coding standard to have an empty line at the begin of each if block ?
I think that make code longer and hard to follow....

DIALIN-1 10 Dec 2019

I don't like if that's pep8 (python coding style) or what ever We need to have a subset of it for ourselves. and it's OK.

DIALIN-1 11 Dec 2019

RESOLVED

DG-DEN-1125-1 10 Dec 2019

Copy & paste from one of my mode modules? Change to when you created this file.

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

HD-DEN-431-1 30 Dec 2019

There are macros in Common.h for getting high and low bytes of a word.

DIALIN-1 11 Dec 2019

RESOLVED.

DIALIN-1 11 Dec 2019

RESOLVED.

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

DIALIN-1 12 Dec 2019

Done

UI-DEN-1090-1 19 Dec 2019

It's not inconsistent any space has a meaning.
I align signal/slots to identify incorrect connections.

DIALIN-1 12 Dec 2019

Done

UI-DEN-1090-1 19 Dec 2019

Let's discuss as a Team whether it makes sense to centralize these as LETTER_CONST in one place or leave it as is.

UI-DEN-1090-1 19 Dec 2019

RESOLVED

UI-DEN-704-1 05 Dec 2019

Line up onRead() slot with frameReceived()... e.g. onCANFrameReceived()

DG-DEN-1125-1 20 Dec 2019

Done!

HD-DEN-431-1 30 Dec 2019

Only one (1) extra line at the end of each file.

HD-DEN-431-1 06 Jan 2020

This code belongs to Sean.

HD-DEN-431-1 06 Jan 2020

Changed the value to 0.

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-1125-1 13 Dec 2019

I just had to go through all my HD code to address spacing. Should have spaces in brackets ( [ or ( or { ) and between items in lists.

HD-DEN-431-1 30 Dec 2019

I would reverse the order of arguments.

HD-DEN-431-1 30 Dec 2019

Only one (1) extra line at the end of each file.

HD-DEN-431-1 03 Jan 2020

Why the space?