•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

Move to top of scope instead of top of function.

HD-DEN-431-1 30 Dec 2019

Please remember to remove all of this test code before merging the branch.

HD-DEN-431-1 03 Jan 2020

shorten the length of the argument you are using as length since you are only filling the txBuffer and it can't have more than 127U.
And it's using more space (at least 3 bytes) than requires.

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 07 Jan 2020

Moved the local variable into the scope

HD-DEN-431-1 30 Dec 2019

Why do we care if an unused bit is set?

HD-SPR4-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-704-1 05 Dec 2019

I was going to use connect but the parent has one then it will override it which is wrong.
So I changed it to connection.

DIALIN-1 26 Nov 2019

I wouldn't say it's ignored. I would say it's already a multiple of 8 in the "else" case - so no need to pad it.

HD-DEN-1404-1 16 Jan 2020

Done

UI-DEN-704-1 03 Dec 2019

RESOLVED.

DG-DEN-1125-1 16 Dec 2019

Done

DG-DEN-1125-1 11 Dec 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-1404-1 16 Jan 2020

Yeap. Done

UI-DEN-704-1 05 Dec 2019

It has been done in new codes for DEN-1090 : DEN-1090-1.
But as a general comment its my preferred coding style for readability and its not our rule or requirement.

HD-DEN-759-1 03 Dec 2019

In general,
I would explicitly assign numbers to enums and also categorizing them and put a little gap between each category.

HD-DEN-759-1 05 Dec 2019

I thought we agreed to have spaced between arguments and parentheses?

HD-DEN-759-1 05 Dec 2019

I thought we agreed to have spaced between arguments and parentheses?

HD-DEN-759-1 03 Dec 2019

My intent is to just have a unique ID for each alarm. It's kind of like assigning a trace # to a requirement in an SRS. It's too much trouble to try to keep them in order - you just assign #s as you write them.
I could assign #s to each or comment w/ # to right of each.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

removed

DIALIN-1 26 Nov 2019

Shouldn't this be rst?

DIALIN-1 17 Dec 2019

Created constants for field positions.

DIALIN-1 06 Dec 2019

RESOLVED.

DIALIN-1 05 Dec 2019

OK.
I found what I want.
So why it has not been used for the other hex values ?

DIALIN-1 06 Dec 2019

All I was eluding to was to put the header comment to the method in one line instead of three.

HD-DEN-759-1 04 Dec 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1396-1 09 Jan 2020

Space between two ifs.

HD-DEN-759-1 04 Dec 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-752-2 04 Dec 2019

I would suggest using && operator to reduce complexity of code

DIALIN-1 17 Dec 2019

RESOLVED

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

HD-DEN-759-1 04 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DIALIN-1 11 Dec 2019

RESOLVED.

DG-DEN-1125-1 06 Jan 2020

Done

HD-DEN-759-1 05 Dec 2019

Sorry - must have changed a different line of code. Now done.

UI-DEN-1090-1 19 Dec 2019

This one is a formating of the output console and is only used in this method numbers are just preferences for nicer output.
No use out of this method.

UI-DEN-704-1 19 Dec 2019

For the two eChlid_UI and eChlid_HD which are for UI in UI I prefer to keep them simple to use and read.

HD-DEN-759-1 10 Dec 2019

In group setting, decision was made to use the () rules applied to [].

DG-DEN-1125-1 13 Dec 2019

Why does DG have an off button message?

UI-DEN-704-1 19 Dec 2019

I meant :
"Can Interface has been setup"

like that I have as :
"candump launched"

DIALIN-1 11 Dec 2019

RESOLVED.

HD-DEN-431-1 30 Dec 2019

Let's not assume. Range check "decimal" parameter. Software fault if > 99.

HD-DEN-431-1 30 Dec 2019

Software fault if invalid state.

DIALIN-1 11 Dec 2019

Sometimes Python needs a brief sleep(0.001) or sleep(0.01) to do certain things like SCI/UART/LIN or handle HW interrupts. Without these, Python crashes or throws in a timeout error or warning of some sort. Anywhere else where there is no need to have a sleep, there should be none.