•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-759-1 03 Dec 2019

Why did we disable the msg to UI?

HD-DEN-759-1 03 Dec 2019

Was waiting for Behrouz to update UI side to accept payload change (from empty to confirm/cancel byte). Behrouz updated UI this morning so I've un-commented the payload change.

HD-DEN-759-1 06 Dec 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-1090-1 19 Dec 2019

I love this!

HD-DEN-752-2 04 Dec 2019

RESOLVED IN CODE WALKTHROUGH

UI-DEN-1090-1 30 Dec 2019

that is one operator not two.
This has a meaning and cannot be separated !
If you separate them you get compile error ...

HD-DEN-759-1 06 Dec 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 06 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

UI-DEN-1090-1 19 Dec 2019

Fixed.

DIALIN-1 13 Dec 2019

Replace with PAYLOAD_LENGTH_FIRST_PACKET setup to 3. Please resolve

UI-DEN-704-1 05 Dec 2019

Device creation is too generic, make it more specific "Can interface cannot be initialize"

DIALIN-1 10 Dec 2019

If the send method returns None, that means it sent the message and waited 1 second and got no response.

UI-DEN-1090-1 30 Dec 2019

RESOLVED.

DG-DEN-1125-1 11 Dec 2019

Done

DIALIN-1 26 Nov 2019

Missing channel for CAN ID 0x200 (UI sync broadcast).

DIALIN-1 05 Dec 2019

Its place should be reserved then and must not be used for data.
So when it has been implemented only a simple change will be required.

DIALIN-1 05 Dec 2019

Please Change the Cargo variable name to payload...

DIALIN-1 11 Dec 2019

RESOLVED.

DIALIN-1 11 Dec 2019

RESOLVED.

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

DG-DEN-1125-1 13 Dec 2019

I think you should add the HD Alarm channel (as an "IN") so you get the system alarm status.

DG-DEN-1125-1 17 Dec 2019

Leo, please make spacing consistent throughout the entire DG code base, this is a must because of our updated C coding standard. Thanks!

HD-DEN-759-1 12 Dec 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 12 Dec 2019

Done

DIALIN-1 11 Dec 2019

Extra line

DIALIN-1 12 Dec 2019

RESOLVED.

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

HD-DEN-431-1 06 Jan 2020

Done!

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

DG-DEN-1125-1 20 Dec 2019

Will add later if needed. RESOLVED IN CODE WALKTHROUGH

HD-DEN-431-1 06 Jan 2020

Added #defines for the years

DG-DEN-1125-1 20 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DG-DEN-1125-1 20 Dec 2019

Done!

DG-DEN-1125-1 20 Dec 2019

Done!

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 06 Jan 2020

Changed it to isBufferOk.

HD-DEN-431-1 30 Dec 2019

Use #defines for 2000 and 1970.

HD-DEN-431-1 07 Jan 2020

I have a toggle macro in use on my branch.

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-1125-1 13 Dec 2019

When will this reflect the DG modes from DG SRS?

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

Define constants for 2000, 1970, etc.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

It doesn't look like the transfer failed here. Should this be set to zero?

HD-DEN-431-1 30 Dec 2019

bufferLength should be range checked. Or does setMibSPIBufferLength() range check it?

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.