•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-759-1 14 Nov 2019

Value "13", which is ...?

UI-DEN-608-1 28 Oct 2019

For now it's 250000 and coordinated with FW.
When settings and configuration module implemented this will be set able.

HD-DEN-759-1 06 Dec 2019

Agreed.

HD-DEN-759-1 14 Nov 2019

Value "15", which is ...?

HD-DEN-759-1 08 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-SPR5-1 05 Nov 2019

I think it's helpful to align the columns. I could add an extra space to all columns to keep alignment, but didn't see the point.

HD-DEN-759-1 14 Nov 2019

Value 14, which is ...?

HD-SPR5-1 05 Nov 2019

I would add 2 spaces after single digit numbers, 1 space after double digit numbers, and no space after triple digit numbers. This will make them all align.

HD-SPR5-1 05 Nov 2019

Consistency in spacing between CRC numbers (some have spaces, some don't, recommending spacing among all).

DIALIN-1 13 Dec 2019

4 to become a CONSTANT defined somewhere else.

HD-DEN-759-1 07 Nov 2019

It's just a placeholder for now. It's currently set so that a 0 to 600 mL/min ramp will take 1 second. For the moment it's fixed. Blaine said he may fix it in the motor controller once we understand our needs better so firmware may not have to worry about it in the end anyway.

HD-DEN-752-1 08 Nov 2019

U32 is unsigned 32 bit integer. S32 is signed 32 bit integer. F32 is float. These are possible types of data that we might want to log with the triggering of an alarm (e.g. if we get a high pressure alarm, what was the pressure that triggered it?).

HD-DEN-759-1 07 Nov 2019

How did this compile?

HD-SPR3-1 14 Nov 2019

RESOLVED

HD-MASTER-1 14 Nov 2019

RESOLVED

HD-DEN-759-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "36", which is ...?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "33", which is ...?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "29", which is ...?

HD-SPR3-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 14 Nov 2019

Value "26", which is ...?

HD-DEN-759-1 14 Nov 2019

Value "25", which is ...?

HD-DEN-759-1 14 Nov 2019

Value "23", which is ...?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "19", which is ...?

HD-DEN-759-1 15 Nov 2019

Explicitly explain "0", 1, or 2, ...

HD-DEN-759-1 14 Nov 2019

Value "12", which is ...?

UI-DEN-1396-1 09 Jan 2020

If unit tests were removed, where are the new unit tests?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 03 Dec 2019

This is temporary test code (per comment).

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 26 Nov 2019

I'm ok with sleep generally, but not sure it's appropriate here as it is currently implemented.
Here, it appears we're pacing ourselves at no more than 1000 (packets or messages?) per second. Maybe ok over time or maybe not - what if we're publishing more than 1000 packets per second when all is said and done? But even if we're not publishing that many packets, I imagine data may come in spurts that will exceed this pace. Is there a buffer holding received packets until this loop "receives" them? If so, how deep is the buffer? If not, I fear we may drop some packets.

LEAHI-DD-FIRMWARE-LDT-2198-1 11 Sep 2025

Removed

HD-DEN-759-1 04 Dec 2019

RESOLVED in CODE WALKTHROUGH.

DG-DEN-1125-1 06 Jan 2020

Done

HD-DEN-759-1 26 Nov 2019

It's a TI example file. No copyright on it. And we've customized it a little, so decision made to absorb it as our own.

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 05 Dec 2019

Fixed.

UI-DEN-1090-1 30 Dec 2019

I would recommend putting the extra spaces after the += sign rather than between the variable and its property.

DIALIN-1 03 Dec 2019

Negative values are allowed for flow rates. Negative indicates reverse direction. I have to assume tester knows what they're commanding.

DG-DEN-1125-1 20 Dec 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-1 12 Dec 2019

Behrouz,
If you are suggesting a change wrt PEP8 coding standard, that is fine. But, you will also need to make that change to our Python coding standard, which is currently an exact copy of the PEP8 coding standard for Python. What is the decision?

HD-DEN-759-1 06 Dec 2019

Done.