Comment Search

RESOLVED.

I do have a document folder where I check for doxygen output locally

Isn't there a library or a method that already does this?

Message structure defined in our Messages spreadsheet and eventually in our SDDs.

Done

How is the message Timeout!!!! related to received_message being equal to None?

Extra line

Updated and added keyword

RESOLVED.

Because this will be a common file. I don't think it will be worth to go through that exercise. If this was unique with DG, I would agree with the comment.

RESOLVED

Remove OFF Button message.

Some Constants are one time use and doesn't add any value to the code to collect them in one place.

This code is for test to be able to enable or disable CanInterface , MessageDispatcher console out to be able to debug without rebuild even on target.
And I mentioned at top of the code that it's a Test code for debuging

Same here, These are aligned parameters as I mentioned to better identify the code bugs.

Added #defines for the years

Stop Button removed because none on DG.

"{" should be on separate line (throughout code).

There are macros in Common.h for getting high and low bytes of a word.

length should be range checked.

I understood the usage, thanks.

removed

uiDidCommunicate is latched. It is useful to know that UI came up and was communicating at some time. uiIsCommunicating is cleared when the getter function is called so the UI has to keep communicating to set the flag again and again (like a comm watchdog).

Very good point does it build if the definition is not present at the function definition ?

RESOLVED in CODE WALKTHROUGH.