•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-1 26 Nov 2019

Make 2000 a centralized parameter at the top of the file or class.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

DIALIN-1 26 Nov 2019

With the number of arguments, one if and elif might not be enough to handle all cases.

DIALIN-1 10 Dec 2019

Done.

DG-DEN-1125-1 11 Dec 2019

Done. Other IDs will be eliminated as we move along.

DIALIN-1 13 Dec 2019

RESOLVED.

DG-DEN-1125-1 11 Dec 2019

RESOLVED IN CODE WALKTHROUGH

DIALIN-1 26 Nov 2019

How is the message Timeout!!!! related to received_message being equal to None?

DIALIN-1 11 Dec 2019

RESOLVED.

DG-DEN-1125-1 16 Dec 2019

It is just for now. Cleaning needs to happen.

DIALIN-1 05 Dec 2019

What is the 5th element?
It has been mentioned every where with no definition.

DIALIN-1 17 Dec 2019

funny that there were two cargo(s).
One has been changed only.
resolve for now.

DIALIN-1 17 Dec 2019

Two cargo(s)
resolved for now

DIALIN-1 05 Dec 2019

How this message has been split in section?
How next person will now the structure?

DG-DEN-1125-1 20 Dec 2019

Done!

UI-DEN-1090-1 19 Dec 2019

Replace 2 with LETTER_CONST and centralize all of them on top of the code.

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

HD-DEN-431-1 30 Dec 2019

Only as a suggestion : I would create a toggle function since you used the same code @258 as well.

HD-DEN-431-1 07 Jan 2020

Please change it to SHIFT ...

HD-DEN-431-1 06 Jan 2020

Yes, the commented code is only for calling the API functions somewhere from outside. I marked that section as test code and I will delete it before merging.

HD-DEN-431-1 06 Jan 2020

Removed the space.

HD-DEN-431-1 06 Jan 2020

Removed the extra lines.

HD-DEN-431-1 06 Jan 2020

Done!

HD-DEN-431-1 06 Jan 2020

This is Sean's code.

HD-DEN-1312-1 06 Jan 2020

Not new. Bitbucket shows sys_core.asm was always in project.

HD-DEN-431-1 06 Jan 2020

Software fault will be added.

HD-DEN-431-1 06 Jan 2020

Added #define for the years.

HD-DEN-431-1 06 Jan 2020

This code will be removed prior to merging this branch to master.

DG-DEN-1125-1 07 Jan 2020

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

Throughout module - function declarations with no parameters should have void.

HD-DEN-431-1 07 Jan 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-431-1 30 Dec 2019

Should there be an alarm triggered here?

HD-DEN-431-1 30 Dec 2019

Doesn't RTC be initialized at the beginning since it might be initialized to be used by the other modules ?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

DIALIN-ACK-1 01 Apr 2020

RESOLVED.

HD-DEN-431-1 07 Jan 2020

Move to top of scope where i is used.

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 26 Nov 2019

What is FAUL?

HD-DEN-1312-1 06 Jan 2020

Add extra space to all for legibility

HD-DEN-1404-1 16 Jan 2020

Done!

HD-DEN-759-1 06 Dec 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 05 Dec 2019

I thought we agreed to have spaced between arguments and parentheses?

HD-DEN-759-1 03 Dec 2019

Make this a constant you call here.

HD-DEN-759-1 03 Dec 2019

Space between arithmetic signs.

DIALIN-1 26 Nov 2019

What about if not?

UI-DEN-1090-1 30 Dec 2019

I agree that it's a little bit redundant but after facing an error I found a subject and this approach was recommended and it worked for me.
This happens since I need to convert array of bytes to float value and then to variant which GUI understands and during this conversion some values get more that expected values after decimal point.

HD-DEN-759-1 03 Dec 2019

This is engineering code for running on eval board (per #ifdef). I will remove the whole #ifdef at some point.

UI-DEN-608-4 04 Dec 2019

Method needs to have verb.

HD-DEN-759-1 03 Dec 2019

What is the difference between UI is communicating and UI did communicate?