•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-759-1 14 Nov 2019

Value "30", which is ...?

HD-DEN-759-1 14 Nov 2019

Value "31", which is ...?

HD-DEN-759-1 07 Nov 2019

Recommending adding this to the comments.

HD-DEN-759-1 08 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 07 Nov 2019

How do we know that these are the only parameters that are needed to sense and control the blood pump? Is this list planned to be changed?

HD-DEN-759-1 08 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "37", which is ...?

HD-DEN-759-1 14 Nov 2019

There is no need to check in *.pyc files, these are compiled Python files at run time.

HD-MASTER-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 14 Nov 2019

Value "34", which is ...?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "32", which is ...?

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 15 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-DEN-759-1 14 Nov 2019

Value "22", which is ...?

HD-DEN-759-1 14 Nov 2019

Value "21", which is ...?

HD-SPR4-1 24 Oct 2019

Why is ? operator not readable?

UI-DEN-608-1 28 Oct 2019

RESOLVED.

UI-DEN-608-1 28 Oct 2019

Have we coordinated with FW Team to make sure this is the fixed CAN Bus bit rate that is planned to be used?

UI-DEN-1090-1 19 Dec 2019

RESOLVED.

UI-DEN-1396-1 14 Jan 2020

RESOLVED.

UI-DEN-626-1 24 Oct 2019

Thanks for the comment.

static class member variable can not be initialized in header.
Please take a look at the applicationcontroller.cpp@21.
It has been initialized with nullptr.

Note : To see the whole file content on the top right click on the "View" menu and select "Full Context"

HD-DEN-759-1 14 Nov 2019

Here it takes value "2", which corresponds to what?

TEST-1 28 Oct 2019

Reply comment.

TEST-1 28 Oct 2019

resolved

HD-SPR4-1 24 Oct 2019

I think this should be clear enough. MSB stands for most significant BYTE, so it should be clear we are masking off 8 bits.

HD-SPR4-1 29 Oct 2019

Generated from HALCoGen

HD-SPR4-1 25 Oct 2019

Shouldn't this be |= . If yes, rethink for the remainder of the function in this module

HD-SPR4-1 24 Oct 2019

rename data to dataPtr

HD-SPR4-1 25 Oct 2019

as is RESOLVED IN CODE WALKTHROUGH

HD-SPR4-1 25 Oct 2019

as is RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 26 Nov 2019

RESOLVED in CODE WALKTHROUGH.

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 07 Nov 2019

I believe there will be during rinseback and possibly during prime and de-prime sequences.

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR5-1 31 Oct 2019

There will be several states between these where some sensors/ADCs will be configured before we get to the next. Waiting for FPGA/hardware to implement.
I'll add a comment for now.

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

UI-DEN-704-1 05 Dec 2019

Same comment as before. Verb.

HD-SPR5-1 31 Oct 2019

Why so much space between cases? One space shall suffice.

UI-DEN-704-1 20 Dec 2019

RESOLVED

HD-MASTER-1 15 Nov 2019

RESOLVED IN CODE WALKTHROUGH

TEST-1 04 Nov 2019

Not much code here...

HD-DEN-759-1 14 Nov 2019

These s/w faults will be all over the place. For logging purposes, I wanted to be able to determine which specific s/w fault was triggered and why. So I'm triggering the fault with 2 alarm data elements. First is a unique s/w fault # so I can go find it in the code. The Second is the value that caused the fault so I can know what the s/w saw when the fault was triggered. I'm open to suggestions on the unique # parameter. I could make (and maintain) a large enum for all of the s/w fault scenarios.

HD-DEN-759-1 14 Nov 2019

Value "35", which is ...?

HD-SPR5-1 05 Nov 2019

RESOLVED in CODE WALKTHROUGH.